Skip to content

msglist: Spoilers should always grow downward when they open #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisbobbe opened this issue Feb 26, 2024 · 3 comments
Open

msglist: Spoilers should always grow downward when they open #536

chrisbobbe opened this issue Feb 26, 2024 · 3 comments
Labels
a-msglist The message-list screen, except what's label:a-content beta feedback Things beta users have specifically asked for

Comments

@chrisbobbe
Copy link
Collaborator

With #503, we'll have support for spoilers! It has a glitch that won't be straightforward to fix, though, so I'm filing this to be worked on later.

The message list's growth direction is up, not down. As a result, when you open a spoiler, it grows up, but it would be better if it grew down, in the direction of the "expand" arrow. Here's what #503 looks like:

Feb-26-2024 14-36-29

It's possible that we'll eventually build the message list out of two back-to-back slivers, with opposite growth directions, instead of just one sliver that grows upward. This approach is being considered for a few issues:

If that happens, then I guess spoilers might sometimes naturally grow downward, but only if they happened to be in the sliver that grows downward.

@gnprice gnprice added this to the Launch milestone Feb 26, 2024
@gnprice gnprice added the a-msglist The message-list screen, except what's label:a-content label Feb 26, 2024
@Puneet2504

This comment was marked as off-topic.

@gnprice

This comment was marked as off-topic.

@gnprice gnprice modified the milestones: Launch, Post-launch May 9, 2024
@gnprice
Copy link
Member

gnprice commented May 14, 2024

@gnprice gnprice added the beta feedback Things beta users have specifically asked for label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-msglist The message-list screen, except what's label:a-content beta feedback Things beta users have specifically asked for
Projects
Status: No status
Development

No branches or pull requests

3 participants