msglist: Leave blank space for "mark as read" button so using it doesn't cause messages to shift #562
Comments
gnprice
added
a-msglist
|
Hello, I have been going over the codebase for a couple of days now to understand the project more and read about Zulips best git practices. I would love the chance to work on this project and work on this issue. I have been able to locate which file I need to work on to fix this issue and I have started working on it. |
|
I have been able to fix this issue by updating the MarkAsReadWidget. Currently, I am trying to find a way to update the existing tests. The tests were previously written to check if the size of the widget > 0, but that won't work anymore since the widget will always have a size. |
|
Hi @abelaba, welcome. I've assigned you the issue. For questions about details of the code, the best place would be a chat thread in In general, one thing we try to do when writing tests is to write them in a way that reflects the UI as the user sees it. So: as far as the user is concerned, what's different when the button is shown vs. when it's not shown? After your changes, the size of that widget will be the same in both cases; but there will be other things that are different. So then try to write a test that checks for one of those differences. If you have follow-up questions after spending some time trying to do that, please go ahead and start a thread in |
…n't cause messages to shift This commit addresses the issue of the message list shifting downwards when the "mark as read" button is pressed. The previous implementation would return an empty widget when the button was pressed and cause the message list to shift down. Now it takes a widget with a definite height, which is equal to the size of the button and won't cause the message list to shift down. Fixes: zulip#562
…n't cause messages to shift This commit addresses the issue of the message list shifting downwards when the "mark as read" button is pressed. The previous implementation would return an empty widget when the button was pressed and cause the message list to shift down. Now it takes a widget with a definite height, which is equal to the size of the button and won't cause the message list to shift down. Fixes: zulip#562
…n't cause messages to shift This commit addresses the issue of the message list shifting downwards when the "mark as read" button is pressed. The previous implementation would return an empty widget when the button was pressed and cause the message list to shift down. Now it takes a widget with a definite height, which is equal to the size of the button and won't cause the message list to shift down. Previously there used to be an empty widget below the "mark as read" button, but that has also been removed. Fixes: zulip#562
…n't cause messages to shift This commit addresses the issue of the message list shifting downwards when the "mark as read" button is pressed. The previous implementation would return an empty widget when the button was pressed and cause the message list to shift down. Now it takes a widget with a definite height, which is equal to the size of the button and won't cause the message list to shift down. Fixes: zulip#562
…n't cause messages to shift This commit addresses the issue of the message list shifting downwards when the "mark as read" button is pressed. The previous implementation would return an empty widget when the button was pressed and cause the message list to shift down. Now it takes a widget which will display the button based on the opacity level and will disable the region the button holds once the button is pressed, thus won't cause the message list to shift down. Fixes: zulip#562
…n't cause messages to shift This commit addresses the issue of the message list shifting downwards when the "mark as read" button is pressed. The previous implementation would return an empty widget when the button was pressed and cause the message list to shift down. Now it takes a widget which will display the button based on the opacity level and will disable the region the button holds once the button is pressed, thus won't cause the message list to shift down. Fixes: zulip#562
…n't cause messages to shift This commit addresses the issue of the message list shifting downwards when the "mark as read" button is pressed. The previous implementation would return an empty widget when the button was pressed and cause the message list to shift down. Now it takes a widget which will display the button based on the opacity level and will disable the region the button holds once the button is pressed, thus won't cause the message list to shift down. Fixes: zulip#562
…n't cause messages to shift This commit addresses the issue of the message list shifting downwards when the "mark as read" button is pressed. The previous implementation would return an empty widget when the button was pressed and cause the message list to shift down. Now it takes a widget which will display the button based on the opacity level and will disable the region the button holds once the button is pressed, thus won't cause the message list to shift down. Fixes: zulip#562
A request from @terpimost. See chat thread.
This is a sort of followup to #400.
The text was updated successfully, but these errors were encountered: