Skip to content

Commit 4ad5be2

Browse files
author
Fabien Coelho
committed
rework actions resilience
1 parent 868addc commit 4ad5be2

File tree

3 files changed

+19
-23
lines changed

3 files changed

+19
-23
lines changed

.github/workflows/docs.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ jobs:
1111
- name: Set up Python
1212
uses: actions/setup-python@v5
1313
- name: Install dependencies
14-
run: make venv.update
14+
run: make VENV= venv.update
1515
- name: Check documentation syntax
16-
run: make check.docs
16+
run: make VENV= check.docs
1717
- name: Generate documentation
18-
run: make docs
18+
run: make VENV= docs
1919
- name: Upload to GitHub Pages
2020
# FIXME what is the difference with deploy below?
2121
uses: actions/upload-pages-artifact@v2

.github/workflows/package.yml

+1-7
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,13 @@ jobs:
1212
matrix:
1313
python-version: ["3.10", "3.11", "3.12"]
1414
steps:
15-
# Setup
1615
- uses: actions/checkout@v4
1716
- name: Set up Python ${{ matrix.python-version }}
1817
uses: actions/setup-python@v5
1918
with:
2019
python-version: ${{ matrix.python-version }}
21-
# Dependencies
2220
- name: Install Python Dependencies
23-
# run: make VENV= venv
24-
run: |
25-
pip install -U pip
26-
pip install -e .[dev,doc]
27-
# Checks
21+
run: make VENV= venv
2822
- name: Check with pyright
2923
run: make VENV= check.pyright
3024
- name: Check with ruff

Makefile

+15-13
Original file line numberDiff line numberDiff line change
@@ -4,45 +4,45 @@ SHELL = /bin/bash
44
.ONESHELL:
55

66
MODULE = FlaskTester
7+
VENV = venv
78

89
F.md = $(wildcard *.md)
910
F.pdf = $(F.md:%.md=%.pdf)
1011

1112
# PYTHON = /snap/bin/pypy3
1213
# PYTHON = python3
1314
PYTHON = python
14-
PIP = venv/bin/pip
1515

1616
.PHONY: check check.mypy check.ruff check.pytest check.demo check.coverage check.docs
1717
check.mypy: venv
18-
source venv/bin/activate
18+
[ "$(VENV)" ] && source $(VENV)/bin/activate
1919
mypy --implicit-optional --check-untyped-defs $(MODULE).py
2020

2121
check.pyright: venv
22-
source venv/bin/activate
22+
[ "$(VENV)" ] && source $(VENV)/bin/activate
2323
pyright $(MODULE).py
2424

2525
# E127,W504
2626
check.ruff: venv
27-
source venv/bin/activate
27+
[ "$(VENV)" ] && source $(VENV)/bin/activate
2828
ruff check --ignore=E227,E402,E501,E721,F401,F811 $(MODULE).py
2929

3030
check.pytest: venv
31-
source venv/bin/activate
31+
[ "$(VENV)" ] && source $(VENV)/bin/activate
3232
$(MAKE) -C tests check
3333

3434
check.coverage: venv
35-
source venv/bin/activate
35+
[ "$(VENV)" ] && source $(VENV)/bin/activate
3636
$(MAKE) -C tests check.coverage
3737

3838
# MD013: line length
3939
check.docs:
40-
source venv/bin/activate
40+
[ "$(VENV)" ] && source $(VENV)/bin/activate
4141
pymarkdown -d MD013 scan *.md
4242
sphinx-lint docs/
4343

4444
check: venv
45-
source venv/bin/activate
45+
[ "$(VENV)" ] && source $(VENV)/bin/activate
4646
type $(PYTHON)
4747
$(MAKE) check.mypy
4848
$(MAKE) check.pyright
@@ -53,7 +53,7 @@ check: venv
5353

5454
.PHONY: docs
5555
docs: venv
56-
source venv/bin/activate
56+
[ "$(VENV)" ] && source $(VENV)/bin/activate
5757
$(MAKE) -C docs html
5858
find docs/_build -type d -print0 | xargs -0 chmod a+rx
5959
find docs/_build -type f -print0 | xargs -0 chmod a+r
@@ -72,20 +72,22 @@ clean.venv: clean
7272

7373
.PHONY: venv.update
7474
venv.update:
75-
$(PIP) install -U pip
76-
$(PIP) install -e .[dev,doc]
75+
[ "$(VENV)" ] && source $(VENV)/bin/activate
76+
pip install -U pip
77+
pip install -e .[dev,doc]
7778

7879
# for local testing
7980
venv:
8081
$(PYTHON) -m venv venv
8182
$(MAKE) venv.update
8283

8384
$(MODULE).egg-info: venv
84-
$(PIP) install -e .
85+
[ "$(VENV)" ] && source $(VENV)/bin/activate
86+
pip install -e .
8587

8688
# generate source and built distribution
8789
dist: venv
88-
source venv/bin/activate
90+
[ "$(VENV)" ] && source $(VENV)/bin/activate
8991
$(PYTHON) -m build
9092

9193
.PHONY: publish

0 commit comments

Comments
 (0)