Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_edge with auto_simplify is incorrect in Multigraph #259

Open
boldar99 opened this issue Jul 16, 2024 · 2 comments
Open

add_edge with auto_simplify is incorrect in Multigraph #259

boldar99 opened this issue Jul 16, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@boldar99
Copy link
Contributor

It incorrectly changes scalars, and it sometimes can't add self-loops.

For a reference, the new tests in #258 don't work if auto_simplify is enabled.
@jvdwetering jvdwetering added the bug Something isn't working label Jan 30, 2025
@jvdwetering jvdwetering mentioned this issue Jan 31, 2025
Closed
@colltoaction
Copy link

I noticed this line throws exceptions. Check zxcalc/zxlive#256 (comment).

pyzx/pyzx/graph/multigraph.py

Line 252 in 7248d5b

s,t,ty = edge

@jvdwetering
Copy link
Collaborator

That should now be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@colltoaction @jvdwetering @boldar99