-
Notifications
You must be signed in to change notification settings - Fork 553
core: Use TriesInMemory
from config
#1590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
core: Use TriesInMemory
from config
#1590
Conversation
This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Hi @ngotchac - sorry for the delay here. Please update the base branch to develop and resolve conflicts (if any). Thanks! |
da97020
to
42e777c
Compare
@pratikspatil024 Done :) |
|
This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
@pratikspatil024 ping :) |
@ngotchac - also change the branch to develop, thanks! |
42e777c
to
60dfe56
Compare
Thanks @ssandeep ; I also rebased it |
60dfe56
to
bbfd018
Compare
@ngotchac - just some minor conflicts and we should be good. Thank you! |
bbfd018
to
bed1413
Compare
@pratikspatil024 Done! |
Hey @ngotchac - seems like something went wrong with the conflict resolution. There seems to be some additional changes now which you did not add. |
The config setting got mistakenly removed in this PR https://github.com/maticnetwork/bor/pull/1300/files
The `tester.fetcher` is already started in `newTester`
bed1413
to
1fdced5
Compare
@pratikspatil024 Indeed, sorry about that! Should be fixed and safer now. Also, I fixed a race condition happening in your tests (see last commit) |
The bool was modified in a goroutine, read in another.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1590 +/- ##
===========================================
- Coverage 48.19% 47.68% -0.51%
===========================================
Files 827 839 +12
Lines 135906 142576 +6670
===========================================
+ Hits 65497 67991 +2494
- Misses 66182 70155 +3973
- Partials 4227 4430 +203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
The config setting got mistakenly removed in this PR https://github.com/maticnetwork/bor/pull/1300/files
Without those changes, we cannot set
TriesInMemory
to anything but the default value.Changes
Checklist
Cross repository changes
Testing
Manual tests
Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it