Skip to content

Conversation

ngotchac
Copy link
Contributor

Description

The config setting got mistakenly removed in this PR https://github.com/maticnetwork/bor/pull/1300/files

Without those changes, we cannot set TriesInMemory to anything but the default value.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Cross repository changes

  • This PR requires changes to heimdall
    • In case link the PR here:
  • This PR requires changes to matic-cli
    • In case link the PR here:

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on amoy
  • I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

@Raneet10 Raneet10 requested a review from a team June 27, 2025 04:27
Copy link

This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 19, 2025
@ngotchac
Copy link
Contributor Author

Friendly ping @lucca30 @cffls :)

@github-actions github-actions bot removed the Stale label Jul 20, 2025
Copy link

This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 11, 2025
@ngotchac
Copy link
Contributor Author

Friendly ping @lucca30 @cffls :)

@github-actions github-actions bot removed the Stale label Aug 15, 2025
@pratikspatil024
Copy link
Member

Hi @ngotchac - sorry for the delay here. Please update the base branch to develop and resolve conflicts (if any). Thanks!

@ngotchac ngotchac force-pushed the ngotchac/tries-in-memory-config branch from da97020 to 42e777c Compare August 20, 2025 12:26
@ngotchac
Copy link
Contributor Author

@pratikspatil024 Done :)

Copy link

Copy link

This PR is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 11, 2025
@ngotchac
Copy link
Contributor Author

@pratikspatil024 ping :)

@github-actions github-actions bot removed the Stale label Sep 13, 2025
@pratikspatil024
Copy link
Member

@ngotchac - also change the branch to develop, thanks!

@ssandeep ssandeep changed the base branch from master to develop October 3, 2025 19:11
@ngotchac ngotchac force-pushed the ngotchac/tries-in-memory-config branch from 42e777c to 60dfe56 Compare October 4, 2025 12:27
@ngotchac
Copy link
Contributor Author

ngotchac commented Oct 4, 2025

Thanks @ssandeep ; I also rebased it

@ngotchac ngotchac force-pushed the ngotchac/tries-in-memory-config branch from 60dfe56 to bbfd018 Compare October 6, 2025 13:19
@pratikspatil024
Copy link
Member

@ngotchac - just some minor conflicts and we should be good. Thank you!

@ngotchac ngotchac force-pushed the ngotchac/tries-in-memory-config branch from bbfd018 to bed1413 Compare October 13, 2025 11:53
@ngotchac
Copy link
Contributor Author

@pratikspatil024 Done!

@pratikspatil024
Copy link
Member

Hey @ngotchac - seems like something went wrong with the conflict resolution. There seems to be some additional changes now which you did not add.

The `tester.fetcher` is already started in `newTester`
@ngotchac ngotchac force-pushed the ngotchac/tries-in-memory-config branch from bed1413 to 1fdced5 Compare October 13, 2025 15:37
@ngotchac
Copy link
Contributor Author

@pratikspatil024 Indeed, sorry about that! Should be fixed and safer now.

Also, I fixed a race condition happening in your tests (see last commit)

@pratikspatil024 pratikspatil024 requested a review from a team October 13, 2025 15:40
The bool was modified in a goroutine, read in another.
Copy link

Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 47.61905% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.68%. Comparing base (c1e1773) to head (7c3a57b).
⚠️ Report is 305 commits behind head on develop.

Files with missing lines Patch % Lines
eth/backend.go 0.00% 19 Missing ⚠️
core/blockchain.go 83.33% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1590      +/-   ##
===========================================
- Coverage    48.19%   47.68%   -0.51%     
===========================================
  Files          827      839      +12     
  Lines       135906   142576    +6670     
===========================================
+ Hits         65497    67991    +2494     
- Misses       66182    70155    +3973     
- Partials      4227     4430     +203     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants