[TECH] Refactorer getPlacementProfileWithSnapshotting et generatePlacementProfile #11468
+12
−290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
alicegoarnisson
force-pushed
the
pix-16658/refacto-getPlacementProfileWithSnapshotting
branch
5 times, most recently
from
24db189 to
0515c0b
Compare
alicegoarnisson
added
👀 Tech Review Needed
👀 Func Review Needed
La-toile-cosmique
approved these changes
Mar 4, 2025
alicegoarnisson
changed the title
|
Coté tech ça me parait ok, sachant qu'en plus les tests passent toujours. Mais aucune idée de comment tester fonctionnellement 🤔 |
Alexandre-Monney
force-pushed
the
pix-16658/refacto-getPlacementProfileWithSnapshotting
branch
from
0515c0b to
1c481da
Compare
C'est sur les résultats de campagnes de collecte de profils 😄 |
|
Func ok en mob 👍 |
Alexandre-Monney
approved these changes
Mar 7, 2025
Alexandre-Monney
added
Tech Review OK
Func Review OK
pix-service-auto-merge
force-pushed
the
pix-16658/refacto-getPlacementProfileWithSnapshotting
branch
from
1c481da to
b17f351
Compare
pix-service-auto-merge
deleted the
pix-16658/refacto-getPlacementProfileWithSnapshotting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
On a deux méthodes, getPlacementProfileWithSnapshotting et getPlacementProfilesWithSnapshotting qui font sensiblement la même chose, avec des paramètres différents.
🥓 Proposition
On garde uniquement getPlacementProfilesWithSnapshotting et on requête la participation à partir de campaignParticipationId pour passer la participation entière au service.
🧃 Remarques
J'ai laissé tomber la refacto de _generatePlacementProfile qui était pas vraiment intéressante pour le coup (on aurait dû ajouter un if dans la méthode, ou alors créer une nouvelle méthode interne juste pour _createUserCompetencesV2 et la création d'un objet PlacementProfile, c'était pas vraiment utile).
😋 Pour tester
Aller sur une campagne de partage de profils -> onglet Résultats
Vérifier que les données du tableau sont cohérentes.