[FEATURE] Avoir l'envoi multiple activé par défaut à la création d'une organisation (PIX-16684) #11551
+99
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
alicegoarnisson
changed the title
alicegoarnisson
changed the title
alicegoarnisson
force-pushed
the
pix-16684/is-multipleSending-by-default
branch
6 times, most recently
from
a5033df to
f52f985
Compare
alicegoarnisson
force-pushed
the
pix-16684/is-multipleSending-by-default
branch
from
a938480 to
2d61d29
Compare
alicegoarnisson
added
👀 Tech Review Needed
👀 Func Review Needed
api/src/organizational-entities/domain/models/OrganizationForAdmin.js
Outdated
Show resolved
Hide resolved
...l-entities/integration/infrastructure/repositories/organization-for-admin.repository.test.js
Outdated
Show resolved
Hide resolved
...l-entities/integration/infrastructure/repositories/organization-for-admin.repository.test.js
Outdated
Show resolved
Hide resolved
...l-entities/integration/infrastructure/repositories/organization-for-admin.repository.test.js
Outdated
Show resolved
Hide resolved
alicegoarnisson
force-pushed
the
pix-16684/is-multipleSending-by-default
branch
4 times, most recently
from
2082a08 to
1181c9e
Compare
…organization is created in admin
…tion is created in tests
alicegoarnisson
force-pushed
the
pix-16684/is-multipleSending-by-default
branch
from
1181c9e to
a8a643f
Compare
|
Func ok en mob 👍 |
Alexandre-Monney
added
Func Review OK
Alexandre-Monney
approved these changes
Mar 7, 2025
…sendingassessment is now a by default feature
alicegoarnisson
force-pushed
the
pix-16684/is-multipleSending-by-default
branch
from
a8a643f to
8afe583
Compare
|
je voulais faire une review func mais je n'arrive pas à créé l'orga, il ne se passe rien quand je clique sur ajouter 😢 |
theotime2005
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
On veut pouvoir, à la création d'une organisation, avoir l'envoi multiple activé par défaut.
🥓 Proposition
A l'instanciation du modèle "OrganizationForAdmin", on vérifie que l'objet qui correspond à la feature "MultipleSendingAssessment" n'est pas déjà créé. S'il n'est pas créé, on passe la valeur "active" de cet objet à "true" avec des params à "null".
🧃 Remarques
Logiquement, on a touché aux tests qui ont un rapport avec les features d'une organisation ou la création d'une organisation, puisque par défaut les organisations auront cette feature-là activée.
😋 Pour tester
Créer une organisation
Vérifier sur scalingo qu'elle a bien la feature "envoi multiple" activée
Aller la désactiver dans l'admin
Vérifier ensuite que la feature est bien désactivée dans scalingo