-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Enregistrer le début d'un passage en tant qu'événement (PIX-16812) #11567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
18bd956
to
2aaa637
Compare
64b8a18
to
b4e2d51
Compare
382261f
to
e644731
Compare
2aaa637
to
99acb2d
Compare
93edf9f
to
3f2f4c9
Compare
3f2f4c9
to
b545564
Compare
yannbertrand
reviewed
Mar 7, 2025
try { | ||
await moduleRepository.getBySlug({ slug: moduleId }); | ||
return await moduleRepository.getBySlug({ slug: moduleId }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vu ensemble, le await
est nécessaire car on est dans un try
/catch
💡
yannbertrand
approved these changes
Mar 7, 2025
in create passage controller Co-authored-by: Diane Cordier <[email protected]>
in create passage controller to usecase Co-authored-by: Diane Cordier <[email protected]>
by returning module for record purposes
by using module content as content hash
b545564
to
b343e33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Contexte
Nous avons mis en place une table
passage-events
pour permettre d'enregistrer les événement Modulix. Des classesPassageStartedEvent
etPassageTerminatedEvent
ont été crée pour ça.🥓 Proposition
Enregistrer le début d'un passage comme événement en utilisant les travaux fais précédemment.
🧃 Remarques
occurredAt
se base sur la date de création en base du passage. Il faudrait qu'il soit passé par le front😋 Pour tester
TODO