Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Enregistrer le début d'un passage en tant qu'événement (PIX-16812) #11567

Merged
merged 4 commits into from
Mar 7, 2025

Conversation

er-lim
Copy link
Contributor

@er-lim er-lim commented Mar 5, 2025

🥞 Contexte

Nous avons mis en place une table passage-events pour permettre d'enregistrer les événement Modulix. Des classes PassageStartedEvent et PassageTerminatedEvent ont été crée pour ça.

🥓 Proposition

Enregistrer le début d'un passage comme événement en utilisant les travaux fais précédemment.

🧃 Remarques

😋 Pour tester

TODO

@er-lim er-lim self-assigned this Mar 5, 2025
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@er-lim er-lim changed the base branch from dev to pix-16810-add-hash-module March 5, 2025 08:21
@er-lim er-lim force-pushed the pix-16812-record-passage-started-event branch from 18bd956 to 2aaa637 Compare March 5, 2025 12:48
@er-lim er-lim force-pushed the pix-16810-add-hash-module branch from 64b8a18 to b4e2d51 Compare March 5, 2025 13:57
@dianeCdrPix dianeCdrPix force-pushed the pix-16810-add-hash-module branch 3 times, most recently from 382261f to e644731 Compare March 6, 2025 14:34
@er-lim er-lim force-pushed the pix-16812-record-passage-started-event branch from 2aaa637 to 99acb2d Compare March 6, 2025 15:02
Base automatically changed from pix-16810-add-hash-module to dev March 6, 2025 15:10
@er-lim er-lim force-pushed the pix-16812-record-passage-started-event branch 2 times, most recently from 93edf9f to 3f2f4c9 Compare March 6, 2025 15:36
@dianeCdrPix dianeCdrPix marked this pull request as ready for review March 6, 2025 15:38
@dianeCdrPix dianeCdrPix requested a review from a team as a code owner March 6, 2025 15:38
@er-lim er-lim force-pushed the pix-16812-record-passage-started-event branch from 3f2f4c9 to b545564 Compare March 7, 2025 07:55
@yannbertrand yannbertrand changed the title [TECH] Enregistrer le début d'un passage en tant qu'événement (PIX-16812) [FEATURE] Enregistrer le début d'un passage en tant qu'événement (PIX-16812) Mar 7, 2025
try {
await moduleRepository.getBySlug({ slug: moduleId });
return await moduleRepository.getBySlug({ slug: moduleId });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vu ensemble, le await est nécessaire car on est dans un try/catch 💡

er-lim and others added 4 commits March 7, 2025 10:17
in create passage controller

Co-authored-by: Diane Cordier <[email protected]>
in create passage controller to usecase

Co-authored-by: Diane Cordier <[email protected]>
by returning module for record purposes
by using module content as content hash
@er-lim er-lim force-pushed the pix-16812-record-passage-started-event branch from b545564 to b343e33 Compare March 7, 2025 09:17
@er-lim er-lim merged commit e0c1c5c into dev Mar 7, 2025
4 checks passed
@er-lim er-lim deleted the pix-16812-record-passage-started-event branch March 7, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants