[FEATURE] Cacher la progression dans les campagnes de Type EXAM (Pix-16921) #11595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
xav-car
force-pushed
the
pix-16921/hide-progression-on-exam
branch
from
db93cc3 to
d3efa94
Compare
xav-car
added
👀 Tech Review Needed
👀 Func Review Needed
xav-car
commented
Mar 7, 2025
| const campaignAssessmentParticipation = | ||
| await campaignAssessmentParticipationRepository.getByCampaignIdAndCampaignParticipationId({ | ||
| campaignId, | ||
| campaignParticipationId, | ||
| buildProgression: campaign.isTypeAssessment, |
There was a problem hiding this comment.
thought j'aime pas trop ça. mais c'est le plus simple sans entrer dans un refacto drift glissage inter galactique 🤐
There was a problem hiding this comment.
juste j'aime bien quand les booleéns ils ont des noms de booléens. shouldBuildProgression ?
xav-car
force-pushed
the
pix-16921/hide-progression-on-exam
branch
from
d3efa94 to
f6cd105
Compare
laura-bergoens
approved these changes
Mar 7, 2025
xav-car
force-pushed
the
pix-16921/hide-progression-on-exam
branch
from
f6cd105 to
0de3478
Compare
laura-bergoens
added
Tech Review OK
🚀 Ready to Merge
Func Review OK
pix-service-auto-merge
force-pushed
the
pix-16921/hide-progression-on-exam
branch
from
0de3478 to
4b0cdf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
La progression se base sur les ke de l'utilisateur, or en mode EXAM nous n'enrichissons pas son compte de ke. ce qui fausse totalement le contenu de la progression
🥓 Proposition
Le cacher, et ne pas faire les appel API permettant de calculer la progression dans le cas d'une campagne de type EXAM
🧃 Remarques
Front déjà fait, il manquait un test
😋 Pour tester
CI au vert. et vérifier qu'une campagne de mode Exam avec une participation non finit. la progression ne s'affiche pas.