[BUGFIX] Le figcaption des éléments images produisent toujours un espace vide
#11602
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
clemlatz
force-pushed
the
fix-module-element-image-ficaption-spacing
branch
from
131366c to
f121c26
Compare
clemlatz
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Je ne suis pas sûr de comment "vérifier que les espacements en dessous des images de sont bien cohérents et pas trop grands." mais ça m'a l'air ok 🤷
PS : j'ai ajouté des ? dans la condition de hasCaption pour réparer les tests, mais peut-être que les propriétés legend et licence sont censées toujours être là, auquel cas il faudrait plutôt corriger le test.
yannbertrand
force-pushed
the
fix-module-element-image-ficaption-spacing
branch
from
f121c26 to
fe8f12c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
L'espacement entre la fin de l'image et la suite (bouton alternative textuelle ou contenu suivant) est trop grand dans le cas où on a pas de caption
🥓 Proposition
Ne pas afficher la
figcaptionsi on en a pas.🧃 Remarques
RAS
😋 Pour tester
Vérifier que les espacements en dessous des images de
bases-clavier-2etbien-ecrire-son-adresse-mailsont bien cohérents et pas trop grands.