[BUGFIX] utilise un nouveau composant pour afficher le markdown (pix-12552) #8947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionelB
added
👀 Tech Review Needed
👀 Func Review Needed
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
lionelB
force-pushed
the
PIX-12552/fix-markdown-html
branch
from
3070d43 to
547702b
Compare
lionelB
commented
May 16, 2024
|
|
||
| // then | ||
| assert.ok(screen.getByRole('link', { name: 'monpix' })); | ||
| assert.ok(screen.getByText(/toto/)); |
There was a problem hiding this comment.
ici on valide que la balise est transformé en texte (idem pour script)
There was a problem hiding this comment.
<toto\/> pour valider que c'est sanitize ?
There was a problem hiding this comment.
edit : le get by text suffit.
lionelB
force-pushed
the
PIX-12552/fix-markdown-html
branch
from
39a218a to
f4f18b8
Compare
|
Test fonc(Lionel) ok ! Plus possible d'injecter du JS dans les champs incriminés ✅ |
xav-car
changed the title
xav-car
added
Func Review OK
lionelB
force-pushed
the
PIX-12552/fix-markdown-html
branch
from
f4f18b8 to
6a85f4a
Compare
xav-car
reviewed
May 21, 2024
orga/package.json
Outdated
| @@ -133,5 +132,9 @@ | |||
| "striptags": "^3.2.0", | |||
| "stylelint": "^16.0.0", | |||
| "webpack": "^5.90.3" | |||
| }, | |||
| "dependencies": { | |||
xav-car
approved these changes
May 21, 2024
xav-car
added
Tech Review OK
🚀 Ready to Merge
and removed
👀 Tech Review Needed
🚀 Ready to Merge
labels
pix-service-auto-merge
force-pushed
the
PIX-12552/fix-markdown-html
branch
from
6a85f4a to
1841907
Compare
lionelB
force-pushed
the
PIX-12552/fix-markdown-html
branch
from
1841907 to
ad88b5f
Compare
lionelB
force-pushed
the
PIX-12552/fix-markdown-html
branch
from
ad88b5f to
4e207f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
On souhaite améliorer la gestion des règles de transformation du html du composant MarkdownToHtml, or celui ci est difficilement paramétrable
🤖 Proposition
On implémente un nouveau composant pour avoir la main sur la transformation html
🌈 Remarques
On a dupliqué le composant dans admin (mais sous la forme classique (fichiers hbs + js)
💯 Pour tester
sur orga
sur admin