Update deployment.yaml: fix ImagrePullSecrets issue #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ImagePullSecrets section is seen as "unknown" if placed under the container section whenever a value for ImagePullSecrets was provided in the values.yaml file. It has to be nested at the same level of the container section, under the spec section
Update deployment.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
addressed and how this is objectively a worthwhile addition to the project.
The ImagePullSecrets section is seen as "unknown" if placed under the container section whenever a value for ImagePullSecrets was provided in the values.yaml file. It has to be nested at the same level of the container section, under the spec section. Like it is it's not possible to use private docker images which requires a secret to be downloaded
Changes
Checklist