RU Translation and Armor Fix #150
Conversation
…e automatic change of the database of basic skills, depending on the set language.
module/utils.js
Outdated
| const pack = game.packs.get("cyberpunk2020.default-skills"); | ||
| // Получаем значение настройки языка | ||
| const selectedLanguage= game.i18n.lang | ||
| console.log("TEST: LANG: ", selectedLanguage) |
There was a problem hiding this comment.
Best to remove this console.log. I'd love for the comments to be in English too. Nothin' against Russian, just means we get a consistent codebase where only one language needs to be known to work in it :)
|
|
||
| // Определяем, какой пакет загружать на основе выбранного языка | ||
| let packName; | ||
| switch(selectedLanguage) { |
There was a problem hiding this comment.
This is a decent way of going about things, though might start to get complex if we do things going off the default skills, for example solo's initiative-boosting. We'd have to look for the skill with the correct name in multiple languages.
I'm thinking in the future, we could possibly have default skills be named as translation keys (eg Cyberpunk.AV), and translate those, whereas user-supplied skills wouldn't be a translation key and wouldn't successfully get translated
There was a problem hiding this comment.
Extra Q: there are other languages without their own skill compendiums. I'd request that this be added, but I don't think either of us are linguistically capable of doing it with Spanish and Italian 😅
| for(let armorArea in armorData.coverage) { | ||
| let location = system.hitLocations[armorArea]; | ||
| if(location !== undefined) { | ||
| armorArea = armorData.coverage[armorArea]; | ||
| location.stoppingPower += armorArea.stoppingPower; | ||
| let armorValue = armorData.coverage[armorArea].stoppingPower; |
There was a problem hiding this comment.
Thanks for the v2 of armor addition! I'd forgotten I needed to account for armour-stacking after the initial implementation.
As mentioned in a later comment, we probably want to stick to comments in one language
I've fixed the armor functionality. Added translations for skills into Russian and automatic adjustment of the base skills database depending on the language set.