feat: implement redis queue #15
Conversation
|
|
||
| const connection = await agent.connections.findById(message.connectionId) | ||
| let connection: ConnectionRecord | null = null | ||
| connection = await this.checkForDuplicateId(message) |
There was a problem hiding this comment.
IMHO this method should return undefined, throwing an Error in case of duplicate like it does right now), and the line const connection = await agent.connections.findById(message.connectionId) remain here.
| private readonly coreMessageService: CoreMessageService, | ||
| ) {} | ||
|
|
||
| async setProcessMessage(redisAvailable: boolean, message: IBaseMessage, connection: ConnectionRecord) { |
There was a problem hiding this comment.
Why don't call this simply processMessage, receiving the message and connection and doing the isRedisAvailable check right here?
|
|
||
| async setProcessMessage(redisAvailable: boolean, message: IBaseMessage, connection: ConnectionRecord) { | ||
| return redisAvailable | ||
| ? await this.messageQueue.add('', { message, connection }) |
There was a problem hiding this comment.
What does that '' mean? Seems a bit awkward to me.
There was a problem hiding this comment.
its a conditional ternary operator. It's used to simplify the "if" condition
There was a problem hiding this comment.
I'm asking about await this.messageQueue.add('', { message, connection }). The first argument is an empty string. What does it mean? Is it the right way of doing it?
There was a problem hiding this comment.
You're right, it's not necessary
README.md
Outdated
| @@ -34,6 +34,8 @@ but likely needed for production and test deployments. | |||
| | POSTGRES_PASSWORD | PosgreSQL database password | None | | |||
| | POSTGRES_ADMIN_USER | PosgreSQL database admin user | None | | |||
| | POSTGRES_ADMIN_PASSWORD | PosgreSQL database admin password | None | | |||
| | REDIS_HOST | Redis database host user | None | | |||
There was a problem hiding this comment.
Add some comments regarding the usage of this Redis (what does it does) and the fact that is optional.
No description provided.