Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update message thread on events #79

Merged
merged 5 commits into from
Feb 15, 2025
Merged

fix: update message thread on events #79

merged 5 commits into from
Feb 15, 2025

Conversation

lotharking
Copy link
Contributor

@lotharking lotharking commented Feb 7, 2025

Summary

Remember the last problem with the message ID. This happened because, when sending messages, we used the threadId instead of the messageId. For this reason, it's necessary to update the threadId in the response, as we use it to identify the message.

Changes

Related Issues

Testing

Checklist

  • I have commented on my code, especially in areas that are hard to understand.
  • I have added only changes relevant to the issue in question.
  • I have added tests to confirm that my fix is effective or that my feature works as intended.
  • I have modified existing tests as needed to accommodate my changes.
  • I have flagged specific areas for further review, if necessary.
  • I have updated the documentation where necessary.

@lotharking lotharking marked this pull request as ready for review February 13, 2025 20:36
@lotharking lotharking requested a review from genaris February 13, 2025 20:36
@genaris genaris merged commit 75291d6 into main Feb 15, 2025
2 checks passed
@genaris genaris deleted the fix/return-threadId branch February 15, 2025 20:35
lotharking added a commit that referenced this pull request Feb 21, 2025
commit 75291d6
Author: andresfv95 <[email protected]>
Date:   Sat Feb 15 15:35:06 2025 -0500

    fix: update message thread on events (#79)

commit 117abdb
Author: andresfv95 <[email protected]>
Date:   Wed Feb 12 17:36:53 2025 -0500

    fix: Updated Yarn to v3.6.4 and updated CI/CD configuration file (#90)

commit 0b95415
Author: andresfv95 <[email protected]>
Date:   Wed Feb 12 15:57:38 2025 -0500

    fix: Updated Yarn to v3.6.4 and updated CI/CD configuration file (#89)

commit cc2743b
Author: andresfv95 <[email protected]>
Date:   Wed Feb 12 15:43:00 2025 -0500

    fix: Updated Yarn to v3.6.4 and updated CI/CD configuration file (#88)

commit c32c831
Author: andresfv95 <[email protected]>
Date:   Wed Feb 12 15:34:39 2025 -0500

    fix: Updated Yarn to v3.6.4 and updated CI/CD configuration file (#87)

commit 00bba87
Author: andresfv95 <[email protected]>
Date:   Wed Feb 12 14:27:59 2025 -0500

    fix: Updated Yarn to v3.6.4 and updated CI/CD configuration file (#86)

commit d6dae0b
Author: andresfv95 <[email protected]>
Date:   Wed Feb 12 13:49:48 2025 -0500

    fix: Updated Yarn to v3.6.4 and updated CI/CD configuration file (#85)

commit cffd45f
Author: andresfv95 <[email protected]>
Date:   Wed Feb 12 13:41:32 2025 -0500

    Fix/yarn deploy packages (#84)

commit 2e79926
Author: andresfv95 <[email protected]>
Date:   Wed Feb 12 13:15:55 2025 -0500

    fix: Updated Yarn to v3.6.4 and updated CI/CD configuration file (#83)

commit d6f1eb6
Author: andresfv95 <[email protected]>
Date:   Wed Feb 12 12:48:20 2025 -0500

    fix: Updated Yarn to v3.6.4 and updated CI/CD configuration file (#82)

commit 5b71ced
Author: andresfv95 <[email protected]>
Date:   Wed Feb 12 04:31:42 2025 -0500

    fix: update Yarn to v3.6.4 and CI/CD configuration file (#81)

commit d92adba
Author: andresfv95 <[email protected]>
Date:   Mon Feb 10 16:09:35 2025 -0500

    test: add unit tests (#77)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants