Feature/ios drm support #5

danielmarino24i · 2019-01-22T10:48:31Z

ISSUE: https://jira.24i.com/browse/PRJ001NXG-82

WIP PR to start adding feedback provided.

Example integration:

<VideoPlayer
                    ref={(ref) => {
                        this.player = ref;
                    }}
                    source={{
                        uri: 'https://edge.pureflix-static-hls.top.comcast.net/eSalt_Media/51/35/-urlsig=O0U9MTU0ODE2NDEyNTtBPTE7Sz0xO1A9MDExMDtTPTk2NWJhMmVkYmIzY2MwMTM3YzMwMjViOGE4MWQ0M2MzY2I1NzcwMzg/1269215299797-1530642225256-master.m3u8',
                        drm: {
                            type: 'fairplay',
                            contentId: 'slaKjktHQxp_',
                            certificateUrl: 'http://pmd205533tn-a.akamaihd.net/eSalt_Media/609/915/fairplay.cer',
                            licenseServer: 'https://fairplay.entitlement.theplatform.com/fpls/web/FairPlay?token=tTzzsJim7CA8kr7ycesWwaD68HAg4LBM&schema=1.0&form=json&account=http://access.auth.theplatform.com/data/Account/2446140407',
                            headers: {
                                'X-AxDRM-Message': 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ2ZXJzaW9uIjoxLCJjb21fa2V5X2lkIjoiYjMzNjRlYjUtNTFmNi00YWUzLThjOTgtMzNjZWQ1ZTMxYzc4IiwibWVzc2FnZSI6eyJ0eXBlIjoiZW50aXRsZW1lbnRfbWVzc2FnZSIsImZpcnN0X3BsYXlfZXhwaXJhdGlvbiI6NjAsInBsYXlyZWFkeSI6eyJyZWFsX3RpbWVfZXhwaXJhdGlvbiI6dHJ1ZX0sImtleXMiOlt7ImlkIjoiOWViNDA1MGQtZTQ0Yi00ODAyLTkzMmUtMjdkNzUwODNlMjY2IiwiZW5jcnlwdGVkX2tleSI6ImxLM09qSExZVzI0Y3Iya3RSNzRmbnc9PSJ9XX19.FAbIiPxX8BHi9RwfzD7Yn-wugU19ghrkBFKsaCPrZmU'
                            },
                            getLicense: (spcString, props) => {
                                const base64spc = btoa(spcString);
                                return fetch(props.source.drm.licenseServer, {
                                    method: 'POST',
                                    headers: {
                                        'Content-Type': 'application/json',
                                        Accept: 'application/json',
                                    },
                                    body: JSON.stringify({
                                        getFairplayLicense: {
                                            releasePid: props.source.drm.contentId,
                                            spcMessage: base64spc,
                                        }
                                    })
                                })
                                    .then(response => response.json())
                                    .then((response) => {
                                        if (response && response.getFairplayLicenseResponse && response.getFairplayLicenseResponse.ckcResponse) {
                                            return response.getFairplayLicenseResponse.ckcResponse;
                                        }
                                        throw new Error('No correct response');
                                    })
                                    .catch((error) => {
                                        console.error('CKC error', error);
                                    });
                            }
                        }
                    }}
                    useTextureView={false}
                    title={title}
                    testID="videoPlayer"
                    // style={styles.container}
                    videoStyle={styles.backgroundVideo}
                    onBack={onBack}
                    onLoad={({ audioTracks: loadedAudioTracks }) => {
                        if (loadedAudioTracks) {
                            this.setState({
                                audioTracks: loadedAudioTracks.map(loadedAudioTrack => ({
                                    language: loadedAudioTrack.title
                                }))
                            });
                        }
                    }}
                    onError={(error) => {
                        console.error('RNV Error', error);
                    }}
                    selectedAudioTrack={{
                        type: 'title',
                        value: audioTrack
                    }}
                />```

hosek

Maybe change drm type to enum to avoid typo and clearly see what types are supported?

danielmarino24i · 2019-01-23T08:44:13Z

@hosek done! thanks

Charlisim · 2019-01-23T13:43:47Z

ios/Video/RCTVideo.m

+    return theData;
+}
+
+- (NSString*)base64forData:(NSData*)theData {


This function can be avoided there is a native method for that:
https://developer.apple.com/documentation/foundation/nsdata/1417833-init

ios/Video/RCTVideo.m

sanderlooijenga · 2019-01-22T11:41:18Z

Video.js

+        })).catch((error) => {
+          NativeModules.VideoManager.setLicenseError(error, findNodeHandle(this._root));
+        });
+      }


What if there's no data or data.spc?

sanderlooijenga · 2019-01-22T11:41:57Z

Video.js

+        });
+      }
+    } else {
+      NativeModules.VideoManager.setLicenseError("No enough data for license override", findNodeHandle(this._root));


"Not enough…" would be a bit better 😁

sanderlooijenga · 2019-01-22T11:42:45Z

Video.js

    });
-
+    


Not needed?

sanderlooijenga · 2019-01-22T11:43:37Z

ios/Video/RCTVideo.m

+                                        [request setValue:value forHTTPHeaderField:key];
+                                    }
+                                }                                
+                                //


ios/Video/RCTVideo.m

sanderlooijenga · 2019-01-24T11:56:42Z

CHANGELOG.md

@@ -1,5 +1,8 @@
 ## Changelog

+### Version 4.3.1


Isn't this a minor update the least?

changed to next so they can decide

sanderlooijenga · 2019-01-24T12:00:28Z

ios/Video/RCTVideo.m

+                                        if([httpResponse statusCode] != 200){
+                                            NSLog(@"Error getting license from %@, HTTP status code %li", url, (long)[httpResponse statusCode]);
+                                            NSError *licenseError = [NSError errorWithDomain: @"RCTVideo"
+                                                                                        code: -1337


Should we add these numbers to an Enum?

refactored to error enum

sanderlooijenga · 2019-01-24T12:02:11Z

README.md

@@ -420,15 +420,18 @@ Platforms: iOS
 Platforms: iOS

 #### headers
-Pass headers to the HTTP client. Can be used for authorization.
+Pass headers to the HTTP client. Can be used for authorization. Headers must be a part of the source object.

 To enable this on iOS, you will need to manually edit RCTVideo.m and uncomment the header code in the playerItemForSource function. This is because the code used a private API and may cause your app to be rejected by the App Store. Use at your own risk.


Is this still the case now?

This is coming from an update of RNV itself. It is related with source > headers, not source > drm > headers

…r to align with player state

… true. requestAudioFocus was being run regardless of there being a src, so I made it so that only gets requested when a src exists.

Support for displaying controls in Android Exoplayer

I'm guessing this change was made to cleanup the code, however it is not functionally identical and may cause issues. Revert until those can be discussed.

Feature Implementation: Recovery from transient internet failures

If an undefined source is accidentally loaded in react-native-video a fatal error SIGABRT will happen and crash the application. This is very difficult to debug since there's apparently no relation between this crash and react-native-video. So this change checks if the URI is empty and, if it is, it throws an error, allowing the user to find out early about the issue. https://cloud.githubusercontent.com/assets/5795227/20283860/08223ba6-aabb-11e6-9fdc-d12d32b3aa9a.png

…-video into feature/ios-drm-support

…roup#1931) this fixes the case on any time you have a react view that displays the video, but it's being rendered with controls but not as a full screen (ie. easily reproducible when you have a tabbar for instance - the reactViewController.view frame shouldnt be the whole screen bounds).

8ntexerra · 2020-03-04T10:31:40Z

@sanjeevghimire
I'm completely sure that this isn't a propper way, but passing prop like that worked for me:
@"spcBase64": [NSString stringWithFormat:@"%@", [spcData base64EncodedStringWithOptions:0]]

Fix video dimensions for HLS streams

Audio mix with other apps for iOS

Implement pending seek fully

# Summary We've been recommending devs use `npx pod-install` since it will attempt to install CocoaPods CLI if it's not available on the computer (cite [React Navigation setup guide](https://reactnavigation.org/docs/getting-started/#installing-dependencies-into-a-bare-react-native-project)). This has proved very useful for Expo users who are now migrating to the bare workflow and want to use community packages in their projects. ## Checklist - [x] I have tested this on a device and a simulator - [x] I added the documentation in `README.md`

* added trackId to exoplayer onLoad callback * added trackInfo to bandwidth callback * syntax fix * syntax fix * version update * sending complete logcat for media playback exception ExoPlaybackException * version bump * package publish changes * Live playback fix * Version bump * import fix * version bump * configurable preferredForwardBufferDuration * configurable preferredForwardBufferDuration * version update * Exposing time * exo player window current tsp * return type * Current window timestamp in epoch * iOS changes * version update * Updated package.json * updated version * CurrentTime bug fix * Updated package.json * Updated currentPlaybackTime * Updated currentPlayback logic * Updated package.json * Bug fix * Added semicolon * updated package.json * Updated ReactVideoView * updated verison * Revert package.json changes * Update ReactVideoView.java * Use standard log * Document preferredForwardBufferDuration (iOS) * Document currentPlaybackTime * Document trackId * Update CHANGELOG.md * Update CHANGELOG.md * Update README.md * Update CHANGELOG.md Co-authored-by: anubansal <[email protected]> Co-authored-by: Sivakumar J <[email protected]> Co-authored-by: parikshit <[email protected]> Co-authored-by: anubansal92 <[email protected]> Co-authored-by: Rishu Agrawal <[email protected]> Co-authored-by: rishu-curefit <[email protected]>

…arzGroup#1862) * update UIInterfaceOrientation in fullscreen * update code

…heWidlarzGroup#1862)" (TheWidlarzGroup#2043) This reverts commit c9096d1.

* Add flag on iOS * Add flag in Android * Add documentation * Add changelog entry * Also set setKeepScreenOn * Fix prop not being set * add preventsDisplaySleepDuringVideoPlayback to exoplayer * Update android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java * Update android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java Co-authored-by: Jens Andersson <[email protected]> Co-authored-by: Anton Tanderup <[email protected]> Co-authored-by: Jens Andersson <[email protected]>

…2053) * Fix exoplayer aspect ratio update on source changes * Update CHANGELOG.md

Add support for customizing back buffer duration and handle network errors gracefully to prevent releasing the player when network is lost.

danielmarino24i requested review from AlbertoMDieguez, davidrielo, pavjacko, petrmrakava, hosek, a user, VladislavStechr and sanderlooijenga January 22, 2019 10:48

hosek approved these changes Jan 22, 2019

View reviewed changes

danielmarino24i requested a review from Charlisim January 23, 2019 09:43

Charlisim reviewed Jan 23, 2019

View reviewed changes

ios/Video/RCTVideo.m Outdated Show resolved Hide resolved

Charlisim approved these changes Jan 23, 2019

View reviewed changes

sanderlooijenga reviewed Jan 24, 2019

View reviewed changes

Ibrahim Sulaiman and others added 15 commits February 6, 2019 03:22

Changed the execution order of initializePlayerControl method in orde…

bd8aa99

…r to align with player state

Fix so background audio from other apps can play when disableFocus is…

739a636

… true. requestAudioFocus was being run regardless of there being a src, so I made it so that only gets requested when a src exists.

Added details to readme and changelog

a55b7e5

Cleanup controls comment

c361b79

Code formatting cleanups for controls

4080349

Merge pull request TheWidlarzGroup#1414 from IbrahimSulai/master

e0fd69e

Support for displaying controls in Android Exoplayer

Rename failureRetryCount to minLoadRetryCount

77411f2

Rename failureRetryCount to minLoadRetryCount

35250fa

Rename failureRetryCount to minLoadRetryCount

e4763c9

Rename failureRetryCount to minLoadRetryCount

420d88d

Revert changes to video group index unset code

2898f8c

I'm guessing this change was made to cleanup the code, however it is not functionally identical and may cause issues. Revert until those can be discussed.

Merge pull request TheWidlarzGroup#1448 from sridhard/master

4424774

Feature Implementation: Recovery from transient internet failures

improve props

4dd1c73

Merge branch 'feature/ios-drm-support' of github.com:24i/react-native…

d759e97

…-video into feature/ios-drm-support

marlonandrade and others added 2 commits February 26, 2020 20:43

Update onLoad event to include videoTracks info

1ecb09a

davidrielo approved these changes Mar 12, 2020

View reviewed changes

euharrison and others added 23 commits April 20, 2020 17:25

add mixWithOthers prop

b4582c6

Update README.md

4157a60

Update index.ios.js

052f49e

Fix video dimensions for HLS streams

cc2e9c4

Changelog

4bc2a72

Compare CGFloats instead

08c7aaa

Merge pull request TheWidlarzGroup#1992 from jenshandersson/feat/hlssize

c579d3c

Fix video dimensions for HLS streams

Merge remote-tracking branch 'upstream/master'

2b33b9e

Update CHANGELOG.md

b8234f8

Merge pull request TheWidlarzGroup#1978 from euharrison/master

c438509

Audio mix with other apps for iOS

Update CHANGELOG, alpha-6 hasn't been released yet

838b99a

Implement pending seek

6bc25f1

Merge pull request TheWidlarzGroup#1994 from jenshandersson/pendingseek

d6a7117

Implement pending seek fully

[ios] Adaptive fullscreen in landscape by device orientation (TheWidl…

c9096d1

…arzGroup#1862) * update UIInterfaceOrientation in fullscreen * update code

Revert "[ios] Adaptive fullscreen in landscape by device orientation (T…

2dd5025

…heWidlarzGroup#1862)" (TheWidlarzGroup#2043) This reverts commit c9096d1.

Upgrade exoplayer to 2.11.4 (TheWidlarzGroup#2034)

7c8c613

Removed JS fullscreening for Android (TheWidlarzGroup#2013)

f395bd1

Always set headers for iOS (TheWidlarzGroup#2014)

9c31948

Fix exoplayer aspect ratio update on source changes (TheWidlarzGroup#…

dbf1a4e

…2053) * Fix exoplayer aspect ratio update on source changes * Update CHANGELOG.md

Merge branch 'master' into feature/ios-drm-support

8c25828

petrmrakava removed request for VladislavStechr and petrmrakava December 21, 2020 13:06

alexejh pushed a commit to simpleTechs/react-native-video that referenced this pull request Jul 29, 2022

VEX-4579: Network loss handling (24i#5)

8087310

Add support for customizing back buffer duration and handle network errors gracefully to prevent releasing the player when network is lost.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/ios drm support #5

Feature/ios drm support #5

danielmarino24i commented Jan 22, 2019 •

edited

Loading

hosek left a comment

danielmarino24i commented Jan 23, 2019

Charlisim Jan 23, 2019

sanderlooijenga Jan 22, 2019

sanderlooijenga Jan 22, 2019

sanderlooijenga Jan 22, 2019

sanderlooijenga Jan 22, 2019

sanderlooijenga Jan 24, 2019

danielmarino24i Jan 25, 2019

sanderlooijenga Jan 24, 2019

danielmarino24i Jan 25, 2019

sanderlooijenga Jan 24, 2019

danielmarino24i Jan 24, 2019

8ntexerra commented Mar 4, 2020

Feature/ios drm support #5

Are you sure you want to change the base?

Feature/ios drm support #5

Conversation

danielmarino24i commented Jan 22, 2019 • edited Loading

hosek left a comment

Choose a reason for hiding this comment

danielmarino24i commented Jan 23, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

8ntexerra commented Mar 4, 2020

danielmarino24i commented Jan 22, 2019 •

edited

Loading