Skip to content
This repository was archived by the owner on Jul 27, 2023. It is now read-only.

Correct FileUploadAction.php class name #145

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

wray-goenergies
Copy link
Contributor

Assuming there is not a reason for the class and file name to differ for this file I propose changing the class name AbstractUploadAction to match the file name FileUploadAction; which will also match the naming conventions of the other action files: FileListAction.php and FileDeleteAction.php.

Assuming there is not a reason for the class and file name to differ for this file I propose changing the class name AbstractUploadAction to match the file name FileUploadAction; which will also match the naming conventions of the other action files: FileListAction.php and FileDeleteAction.php.
@tonydspaniard
Copy link
Member

@wray-goenergies thanks for your contribution. I'll check how that would affect BC and if it does, will merge and publish a major version update

@cebe
Copy link

cebe commented Feb 4, 2019

@tonydspaniard the current state of the file does not allow autoloading it, so I do not see a reason to keep current name. The only way to properly use this code is to copy it to your application.

I am for merging this change.

@tonydspaniard
Copy link
Member

@cebe thanks... you are correct.

@tonydspaniard tonydspaniard merged commit 9df6190 into 2amigos:master Feb 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants