Limit validator set by MaxVal

3Dpass · Apr 26, 2024 · aff32a5 · aff32a5
1 parent b69913c
commit aff32a5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/pallets/validator-set/src/lib.rs b/pallets/validator-set/src/lib.rs
@@ -184,6 +184,9 @@ pub mod pallet {
 
 		#[pallet::constant]
 		type DefaultPeriod: Get<u32>;
+
+		#[pallet::constant]
+		type MaxVal: Get<u32>;
 	}
 
 	#[pallet::pallet]
@@ -325,6 +328,8 @@ pub mod pallet {
 		InvalidDuration,
 		/// Failed to estimate next session.
 		EstimateNextSessionFailed,
+		/// Too many validators.
+		TooManyValidators,
 	}
 
 	#[pallet::hooks]
@@ -854,6 +859,8 @@ impl<T: Config> Pallet<T> {
 	fn do_add_validator(validator_id: T::AccountId, check_block_num: bool) -> DispatchResult {
 		let cur_block_number = <frame_system::Pallet<T>>::block_number();
 
+		ensure!(<Validators<T>>::get().len() < T::MaxVal::get() as usize, Error::<T>::TooManyValidators);
+
 		let item_lock = ValidatorLock::<T>::get(&validator_id).ok_or(Error::<T>::AmountLockedBelowLimit)?;
 		let deposit =
 			if item_lock.0 < cur_block_number  {

diff --git a/runtime/src/lib.rs b/runtime/src/lib.rs
@@ -994,6 +994,7 @@ parameter_types! {
 	pub const MinLockPeriod: u32 = 30 * 24 * HOURS;
 	pub const SlashValidatorFor: u32 = 2 * HOURS;
 	pub const AddAfterSlashPeriod: u32 = 7 * 24 * HOURS;
+	pub const MaxVal: u32 = 1000;
 }
 
 impl pallet_validator_set::Config for Runtime {
@@ -1017,6 +1018,7 @@ impl pallet_validator_set::Config for Runtime {
 	type Slash = Treasury;
 	type DefaultOffset = Offset;
 	type DefaultPeriod = Period;
+	type MaxVal = MaxVal;
 }
 use sp_core::U256;