Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom format specs for JSON #148

Merged
merged 3 commits into from
Aug 22, 2016
Merged

Conversation

3Hren
Copy link
Owner

@3Hren 3Hren commented Aug 22, 2016

@shaitan, part 1: functionality.

@3Hren
Copy link
Owner Author

3Hren commented Aug 22, 2016

Performance regression:

Before:

⇒  ./blackhole-benchmarks
Run on (4 X 1000 MHz CPU s)
2016-06-21 16:56:55
Benchmark                                    Time(ns)    CPU(ns) Iterations
---------------------------------------------------------------------------
formatter.json                                    881        875     791649                1115.91k items/s
formatter.json[route]                            1107       1101     628067                887.084k items/s
formatter.json[route + attr: 1]                  1266       1258     553014                776.236k items/s
formatter.json[route + attr: 5]                  2065       2050     334271                476.418k items/s
formatter.json[route + attr: 5 + unique]         2752       2706     265371                360.829k items/s

After:

⇒  ./build/blackhole-benchmarks --benchmark_filter=formatter\.json
Run on (4 X 1000 MHz CPU s)
2016-08-22 14:58:29
Benchmark                                  Time(ns)    CPU(ns) Iterations
-------------------------------------------------------------------------
formatter.json                                 1013       1009     682594                967.397k items/s
formatter.json[route]                          1231       1228     554825                795.182k items/s
formatter.json[route + attr: 1]                1454       1448     491111                674.306k items/s
formatter.json[route + attr: 5]                2362       2358     300827                414.183k items/s
formatter.json[route + attr: 5 + unique]       2850       2846     240198                343.118k items/s

@3Hren
Copy link
Owner Author

3Hren commented Aug 22, 2016

Closes #147.

@3Hren 3Hren merged commit 0aeaa6a into develop Aug 22, 2016
@3Hren 3Hren deleted the issue/146/custom-format-json branch October 27, 2016 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant