Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(makeProps): Properly Handle Types for defaults #871

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix(makeProps): Properly Handle Types for defaults #871

merged 1 commit into from
Jan 15, 2024

Conversation

FlorianWendelborn
Copy link
Member

@FlorianWendelborn FlorianWendelborn commented Jan 15, 2024 •
edited by carsoli
Loading

makeProps was missing default on ReturnType

@github-actions github-actions bot added the package:kotti-ui @3yourmind/kotti-ui label Jan 15, 2024
FlorianWendelborn
FlorianWendelborn commented Jan 15, 2024
View reviewed changes
Copy link
Member Author

@FlorianWendelborn FlorianWendelborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carsoli carsoli force-pushed the naruto/pre-upgrade/properly-type-defaults-in-make-props branch from 12c9166 to f0ab895 Compare January 15, 2024 18:13
@carsoli carsoli enabled auto-merge January 15, 2024 18:14
@carsoli carsoli merged commit 40073d9 into master Jan 15, 2024
7 checks passed
@carsoli carsoli deleted the naruto/pre-upgrade/properly-type-defaults-in-make-props branch January 15, 2024 18:14
@FlorianWendelborn FlorianWendelborn mentioned this pull request Jan 15, 2024
Merged
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carsoli carsoli carsoli approved these changes

Assignees
No one assigned
Labels
package:kotti-ui @3yourmind/kotti-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorianWendelborn @carsoli