Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kotti): Avoid Using export * as Syntax #873

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

FlorianWendelborn
Copy link
Member

@FlorianWendelborn FlorianWendelborn commented Jan 15, 2024

It’s relatively modern syntax and doesn’t always have perfect tooling support
Removed because it caused problems in the Vue 2.7 branch

Co-Authored-By: Carol Soliman [email protected]

@github-actions github-actions bot added the package:kotti-ui @3yourmind/kotti-ui label Jan 15, 2024
Copy link
Member Author

@FlorianWendelborn FlorianWendelborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It’s relatively modern syntax and doesn’t always have perfect tooling support
Removed because it caused problems in the Vue 2.7 branch
Co-Authored-By: Carol Soliman <[email protected]>
@carsoli carsoli force-pushed the naruto/pre-upgrade/avoid-export-as branch from 7b07eee to a03a097 Compare January 15, 2024 18:16
@carsoli carsoli enabled auto-merge January 15, 2024 18:16
@carsoli carsoli merged commit 290a6ab into master Jan 15, 2024
7 checks passed
@carsoli carsoli deleted the naruto/pre-upgrade/avoid-export-as branch January 15, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:kotti-ui @3yourmind/kotti-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants