Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4 Groups - full IFC GUID and revit ID support #4641

Closed
1 task
carmenfan opened this issue Dec 6, 2023 · 1 comment
Closed
1 task

v4 Groups - full IFC GUID and revit ID support #4641

carmenfan opened this issue Dec 6, 2023 · 1 comment
Labels
backend feature

Comments

@carmenfan
Copy link
Member

Description

We're introducing Revit ID support and also better IFC Guid support in #4552 for ticket groups.

We also need this on v4 groups.

Goals

  • As a user I want my groups to work across revisions if I am providing a BIM model that has persistent IFC guids or Revit IDs

Tasks

TBC
@carmenfan carmenfan self-assigned this Dec 12, 2023
carmenfan added a commit that referenced this issue Jan 9, 2024
@carmenfan
ISSUE #4641 refactor to allow exposure
0a2bfd8
carmenfan added a commit that referenced this issue Jan 9, 2024
@carmenfan
ISSUE #4641 resolve merge comflicts
297331d
carmenfan added a commit that referenced this issue Jan 10, 2024
@carmenfan
ISSUE #4641 more refactoring on the v5 code for v4 to reuse
7294719
carmenfan added a commit that referenced this issue Jan 10, 2024
@carmenfan
ISSUE #4641 changes done
af82739
carmenfan added a commit that referenced this issue Jan 11, 2024
@carmenfan
ISSUE #4641 fix typo
ad4333b
@carmenfan carmenfan mentioned this issue Jan 11, 2024
Merged
carmenfan added a commit that referenced this issue Jan 11, 2024
@carmenfan
ISSUE #4641 bug fixes
8400489
carmenfan added a commit that referenced this issue Jan 11, 2024
@carmenfan
ISSUE #4641 take revId into account when we calculate external Ids
188c4b2
carmenfan added a commit that referenced this issue Jan 11, 2024
@carmenfan
ISSUE #4641 further v4 fixes
0d1d6db
carmenfan added a commit that referenced this issue Jan 12, 2024
@carmenfan
ISSUE #4641 some fixes for v4 tests
6b9eea6
carmenfan added a commit that referenced this issue Jan 12, 2024
@carmenfan
ISSUE #4641 more fixes for tests
96f7cc8
carmenfan added a commit that referenced this issue Jan 12, 2024
@carmenfan
ISSUE #4641 fixed some v5 tests
8da273c
carmenfan added a commit that referenced this issue Jan 12, 2024
@carmenfan
ISSUE #4641 get tickets by id tests all fixed
60d6a20
carmenfan added a commit that referenced this issue Jan 15, 2024
@carmenfan
ISSUE #4641 unit tests fixed
a31d3a4
carmenfan added a commit that referenced this issue Jan 15, 2024
@carmenfan
ISSUE #4641 getMeshesWithParentsId tests added
6865d5d
carmenfan added a commit that referenced this issue Jan 15, 2024
@carmenfan
ISSUE #4641 getExternalIdsFromMetadata tested
ba9f839
carmenfan added a commit that referenced this issue Jan 15, 2024
@carmenfan
ISSUE #4641 tests done for scene processor
c755273
carmenfan added a commit that referenced this issue Jan 15, 2024
@carmenfan
ISSUE #4641 add missing test case for code coverage
289b480
carmenfan added a commit that referenced this issue Jan 15, 2024
@carmenfan
ISSUE #4641 fix code coverage
fc084f9
carmenfan added a commit that referenced this issue Jan 15, 2024
@carmenfan
ISSUE #4641 fix missing dependency
377d287
carmenfan added a commit that referenced this issue Jan 15, 2024
@carmenfan
ISSUE #4641 fix typos
ad67c3c
carmenfan added a commit that referenced this issue Jan 15, 2024
@carmenfan
ISSUE #4641 fix typo in unit test
2968d27
@carmenfan carmenfan mentioned this issue Jan 15, 2024
Merged
carmenfan added a commit that referenced this issue Jan 15, 2024
@carmenfan
ISSUE #4641 fixes
4473643
@carmenfan carmenfan mentioned this issue Jan 15, 2024
Closed
carmenfan added a commit that referenced this issue Jan 15, 2024
@carmenfan
ISSUE #4641 Should be able to reference revisions by tag
1f8fa06
carmenfan added a commit that referenced this issue Jan 15, 2024
@carmenfan
ISSUE #4641 fix tests
089d946
carmenfan added a commit that referenced this issue Jan 17, 2024
@carmenfan
ISSUE #4641 address feedback
6aeb8ef
carmenfan added a commit that referenced this issue Jan 17, 2024
@carmenfan
ISSUE #4641 fix test
b9744fa
carmenfan added a commit that referenced this issue Jan 17, 2024
@carmenfan
ISSUE #4641 fix bug
79d817c
carmenfan added a commit that referenced this issue Jan 17, 2024
@carmenfan
ISSUE #4641 address feedback
88cf4f5
carmenfan added a commit that referenced this issue Jan 18, 2024
@carmenfan
ISSUE #4641 remove entry if there's no objects
8d8206d
@carmenfan
Copy link
Member Author

Merged into #4552

@carmenfan carmenfan removed their assignment Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carmenfan