-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE #4623 - New clipping box toolbar items #4666
Conversation
# Conflicts: # frontend/unity/Build/unity.data.unityweb # frontend/unity/Build/unity.framework.js.unityweb # frontend/unity/Build/unity.wasm.unityweb
…o ISSUE_4477 # Conflicts: # frontend/unity/default/unity/Build/unity.data.unityweb # frontend/unity/default/unity/Build/unity.framework.js.unityweb # frontend/unity/default/unity/Build/unity.wasm.unityweb
…embedded viewers
# Conflicts: # frontend/unity/default/unity/Build/unity.data.unityweb # frontend/unity/default/unity/Build/unity.framework.js.unityweb # frontend/unity/default/unity/Build/unity.wasm.unityweb
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One remaining comment unaddressed (tagged you)
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@The-Daniel i don't know if we're just not understanding each other or what, but it's still happening 😆
So i'm just going to repeat here with more details:
If i click on a view with a clipping plane, it's automatically going into edit mode:
Whereas on staging, I don't see this:
When a user clicks on a view that imposes/changes the clipping plane, it should impose the clip with the toggle set to off i.e. the geometry should be clipped, but I don't want to see the gizmo or the sub toolbar.
@carmenfan Sorry! I had stupidly forgotten to push my changes! There might be 1 small change I have to make that Santiago has just pointed out to me. But I'll make sure I have pushed before I request a review again |
ec5198a
This fixes #4623
Description
Test cases
Try all the new buttons related to the clipping gizmo