Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE #4623 - New clipping box toolbar items #4666

Merged
merged 60 commits into from
Jan 19, 2024
Merged

ISSUE #4623 - New clipping box toolbar items #4666

merged 60 commits into from
Jan 19, 2024

Conversation

The-Daniel
Copy link
Contributor

@The-Daniel The-Daniel commented Jan 4, 2024

This fixes #4623

Description

  • The clipping gizmo can now be controlled by buttons in the toolbar
  • The plane gizmo has a flip button but no scale gizmo mode
  • The box mode has no flip button but does have a scale gizmo mode

Test cases

Try all the new buttons related to the clipping gizmo

sebjf and others added 30 commits September 28, 2023 14:41
# Conflicts:
#	frontend/unity/Build/unity.data.unityweb
#	frontend/unity/Build/unity.framework.js.unityweb
#	frontend/unity/Build/unity.wasm.unityweb
…o ISSUE_4477

# Conflicts:
#	frontend/unity/default/unity/Build/unity.data.unityweb
#	frontend/unity/default/unity/Build/unity.framework.js.unityweb
#	frontend/unity/default/unity/Build/unity.wasm.unityweb
# Conflicts:
#	frontend/unity/default/unity/Build/unity.data.unityweb
#	frontend/unity/default/unity/Build/unity.framework.js.unityweb
#	frontend/unity/default/unity/Build/unity.wasm.unityweb
@carmenfan
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Member

@carmenfan carmenfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remaining comment unaddressed (tagged you)

@The-Daniel The-Daniel requested a review from carmenfan January 17, 2024 14:35
@carmenfan
Copy link
Member

/azp run

@carmenfan carmenfan assigned carmenfan and unassigned Amantini1997 Jan 17, 2024
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Member

@carmenfan carmenfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@The-Daniel i don't know if we're just not understanding each other or what, but it's still happening 😆

So i'm just going to repeat here with more details:

If i click on a view with a clipping plane, it's automatically going into edit mode:
24-01-17 06-15-49

Whereas on staging, I don't see this:
24-01-17 06-17-27

When a user clicks on a view that imposes/changes the clipping plane, it should impose the clip with the toggle set to off i.e. the geometry should be clipped, but I don't want to see the gizmo or the sub toolbar.

@The-Daniel
Copy link
Contributor Author

@carmenfan Sorry! I had stupidly forgotten to push my changes! There might be 1 small change I have to make that Santiago has just pointed out to me. But I'll make sure I have pushed before I request a review again

@The-Daniel The-Daniel requested a review from carmenfan January 18, 2024 11:21
carmenfan
carmenfan previously approved these changes Jan 18, 2024
@carmenfan carmenfan assigned sanmont3drepo and unassigned carmenfan Jan 18, 2024
sanmont3drepo
sanmont3drepo previously approved these changes Jan 18, 2024
Amantini1997
Amantini1997 previously approved these changes Jan 19, 2024
@carmenfan carmenfan merged commit d5669aa into staging Jan 19, 2024
13 of 18 checks passed
@carmenfan carmenfan deleted the ISSUE_4623 branch January 19, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants