Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE #4623 - New clipping box toolbar items #4666
ISSUE #4623 - New clipping box toolbar items #4666
Changes from all commits
94d64b4
1147e83
556b8e8
571d81e
9aec9ed
1f322fe
fb2de1d
ab3e1d2
b94272a
0dd25f4
032a276
84d317e
ab92d61
2239b6c
2b6fc06
75fff7d
af8109a
546b014
7d7f270
584b050
7e6f42a
86309e8
575be68
f3afa5d
3eec0fe
260952f
1645561
c76a1c7
434f3e4
da37f8f
6ae0132
5e89057
adf3765
0167529
cd1d556
05ef7ea
0fdd3df
144efa2
9c58ee0
8af35db
ddbf043
0036217
e6918a1
9b3dd7a
dd95f5c
d01f5a4
309b236
f43305c
ddd709f
b73d3f9
e45d9fb
54684db
e82cb1f
705eb27
f4a090d
34dd35d
818b504
85d566a
1129a3a
ec5198a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tool tip changes
Can we call this
Move
?This should be
Remove
orDelete
.Align to surface
Resize
Can we call this
Sectioning
,Section by plane
,Section by box
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed the disable look isn't prominent enough. we should look into making it more obvious
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@The-Daniel don't think there was any changes for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clicking on a view with clipping plane should then allow me to click on the clip tool to edit the plane - at the moment the bottom tool bar doesn't seems to think there's a clip on the model

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@The-Daniel should not automatically enable the edit mode. It should just set the tool to be the state where there;s a clipping plane, but not in edit mode (i.e. same as you've set the clip, but clicked on the main clipping button to disable the editing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@The-Daniel this was not addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I did fix that at some point but I think my other changes must have reverted it