ISSUE #4699 - Frontend doesn't read ifc/revit ids in groups #4704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-Daniel
approved these changes
Jan 19, 2024
sanmont3drepo
approved these changes
Jan 19, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
sanmont3drepo
requested changes
Jan 19, 2024
sanmont3drepo
approved these changes
Jan 22, 2024
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
carmenfan
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4699
Description
When the frontend receives a chat event that a ticket was updated, if the objects does not have standard _ids (i.e. revit or ifc ids) refetch the group
Test cases
Create a container with an ifc (or revit) revision.
Create a manual group and then update it.
The object count should be correct.
Repeat with a federation that contains the aforementioned container