Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5310 - Resizable table #5361

Merged
merged 41 commits into from
Feb 14, 2025
Merged

Issue 5310 - Resizable table #5361

merged 41 commits into from
Feb 14, 2025

Conversation

Amantini1997
Copy link
Contributor

This fixes #5310

Description

The resizable table is made up of some wrapper components that need using in order for it work:

  • the context component
  • ResizableTable
  • ResizableRow
  • ResizableCell

The resizer lines that you see on hover are always there, but invisible. They get a colour as soon as the user hovers over any, and they are rendered as an overlay to the actual table

Test cases

Try resizing the columns a little bit, test the performance, change templates and tickets, and make sure that everything works

@Amantini1997
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

carmenfan
carmenfan previously approved these changes Feb 3, 2025
@carmenfan
Copy link
Member

Looks good, thanks!

@carmenfan carmenfan assigned sanmont3drepo and unassigned carmenfan Feb 3, 2025
@carmenfan
Copy link
Member

@Amantini1997 actually the project listing looks a bit odd with the updated margin
image

Things I can think of to maybe try:

  1. adjust the card size to fit another one in?
  2. Adjust the card size to make the 6 occupy the whole space
  3. Centre project cards?

@sanmont3drepo
Copy link
Contributor

sanmont3drepo commented Feb 4, 2025

@Amantini1997 actually the project listing looks a bit odd with the updated margin image

Things I can think of to maybe try:

  1. adjust the card size to fit another one in?
  2. Adjust the card size to make the 6 occupy the whole space

This depends on the user's resolution, I think. Users with different resolution might fit more or less partial cards

  1. Centre project cards?

Could work!

@Amantini1997
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

carmenfan
carmenfan previously approved these changes Feb 5, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resizer seems to get slightly more misaligned the further you go across the table
image

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get that
image

Could it be a problem of the rendering engine, causing an apparent offset? In other words, if you change the zoom level, do you still see it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to only be a problem in Firefox

@carmenfan carmenfan merged commit 3f4c73e into staging Feb 14, 2025
11 checks passed
@carmenfan carmenfan deleted the ISSUE_5310 branch February 14, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants