ISSUE #5271 - Ticket filters: jobsandusers select filter form #5391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ists within select already
The-Daniel
changed the title
Amantini1997
requested changes
Feb 6, 2025
.../v5/ui/components/viewer/cards/cardFilters/filtersSelection/tickets/ticketFilters.helpers.ts
Outdated
Show resolved
Hide resolved
frontend/src/v5/ui/components/viewer/cards/cardFilters/filterForm/filterForm.component.tsx
Show resolved
Hide resolved
.../v5/ui/components/viewer/cards/cardFilters/filtersSelection/tickets/ticketFilters.helpers.ts
Outdated
Show resolved
Hide resolved
frontend/src/v5/ui/controls/assigneesSelect/assigneesSelect.component.tsx
Outdated
Show resolved
Hide resolved
frontend/src/v5/ui/controls/assigneesSelect/assigneesSelect.component.tsx
Outdated
Show resolved
Hide resolved
...mponents/viewer/cards/cardFilters/filterForm/filterFormValues/filterFormValues.component.tsx
Outdated
Show resolved
Hide resolved
… exist on tickets within the model
…y don't have a displayValue
Amantini1997
requested changes
Mar 4, 2025
...end/src/v5/ui/controls/assigneesSelect/assigneesSelectMenu/assigneesSelectMenu.component.tsx
Outdated
Show resolved
Hide resolved
.../v5/ui/components/viewer/cards/cardFilters/filtersSelection/tickets/ticketFilters.helpers.ts
Outdated
Show resolved
Hide resolved
sanmont3drepo
approved these changes
Mar 4, 2025
| /> | ||
| <FormHelperText>{helperText}</FormHelperText> | ||
| </FormControl> | ||
| export const MultiSelect = ({ defaultValue = [], className, ...props }: SelectProps) => ( |
There was a problem hiding this comment.
In src\v5\ui\routes\viewer\tickets\ticketsForm\properties\manyOfProperty.component.tsx this component is being used.
manyOfProperty shows a different component depending on the values prop . These components are all FormInputs and the change here changes that.
maybe you should change that reference to FormMultiSelect to keep the same logic?
There was a problem hiding this comment.
I followed the code a little bit more and its using src\v5\ui\controls\searchSelect\searchSelect.component.tsx which uses src\v5\ui\controls\inputs\select\select.component.tsx which in turn uses formcontrol.
Created an issue #5448 to address this, so this comment dont need to be addressed.
Amantini1997
requested changes
Mar 5, 2025
…tor for a property type
Amantini1997
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5271
Description
Adds the jobs and users circles input for when a value is solely jobs and users
If the property has jobsAndUsers and in addition to other values then the usual select will display.
Users will always be shown as their full name - not their username.
The owner property uses the jobs and users circle select
Test cases
Test out the 'Owner property'
Create templates that have a shared property path (module, property, and type are the same) but with different values one of which is jobs and Users