Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 5379 - Pin types in tickets #5400

Merged
merged 10 commits into from
Feb 20, 2025
Merged

Issue 5379 - Pin types in tickets #5400

merged 10 commits into from
Feb 20, 2025

Conversation

sanmont3drepo
Copy link
Contributor

This fixes #5379

Description

  • Now different pin icons are supported
  • in the coords fields in the ticket forms the pin icon reflects the selected pin icon
  • the 3d viewer reflects the pin icon
  • the 2d viewer reflects the pin icon (with the selections con colours
  • The ticket types response from the backend is mocked until the backend feature is implemented

Test cases

  • drop a pin in 2d and 3d for all different types of pin (ticket, bookmark, issue and risk)

@sanmont3drepo sanmont3drepo marked this pull request as draft February 13, 2025 18:33
@sanmont3drepo
Copy link
Contributor Author

Hold until the backend part is merged

Amantini1997
Amantini1997 previously approved these changes Feb 14, 2025
View reviewed changes
@Amantini1997 Amantini1997 marked this pull request as ready for review February 18, 2025 11:53
@carmenfan carmenfan assigned carmenfan and unassigned Amantini1997 Feb 18, 2025
@carmenfan carmenfan self-requested a review February 18, 2025 14:05
@carmenfan
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@carmenfan carmenfan assigned Amantini1997 and unassigned carmenfan Feb 19, 2025
@carmenfan carmenfan merged commit 7566348 into staging Feb 20, 2025
18 of 20 checks passed
@carmenfan carmenfan deleted the ISSUE_5379 branch February 20, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmenfan carmenfan carmenfan approved these changes

@Amantini1997 Amantini1997 Amantini1997 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanmont3drepo @carmenfan @Amantini1997