ISSUE #5309 - Views in tickets comments UI #5447
Conversation
…clicking saved comment view
…multi image extending out of component
…tion. Cleared comment box viewpoint on submit
| @@ -17,10 +17,11 @@ | |||
|
|
|||
| type IProps = { | |||
| className?: any; | |||
| onClick?: () => void; | |||
There was a problem hiding this comment.
Hovering around the camera icon, the tooltip is triggered, but clicking does nothing
oggi.mp4
| @@ -17,10 +17,11 @@ | |||
|
|
|||
| type IProps = { | |||
| className?: any; | |||
| onClick?: () => void; | |||
There was a problem hiding this comment.
Editing a comment in staging sets the min comment height to one line and has a grey contour
Here the min height is much more and the contour is gone
| author, | ||
| images = [], | ||
| metadata, | ||
| isCurrentUserComment = true, | ||
| hasMessage, | ||
| onUploadImages, | ||
| onDeleteImage, | ||
| onEditImage, |
There was a problem hiding this comment.
You can also remove these from the props type and propagate it to the parent component
| deleteCommentReply={() => setCommentReply(null)} | ||
| /> | ||
| )} | ||
| {!readOnly && <CreateCommentBox metadata={commentReply} />} |
There was a problem hiding this comment.
If I click on "reply to comment", then delete the reply, then hit again "reply to comment", the reply is not visible.
This is only true if I do so on the same comment (I try to reply to)
oggi.mp4
| commentReply: ITicketComment | null; | ||
| deleteCommentReply: () => void; | ||
| type CommentBoxProps = Pick<ITicketComment, 'message' | 'images' | 'view'> & { | ||
| onCancel?: () => void; |
There was a problem hiding this comment.
As this component is used both by the create and the edit comment, can you rename this to something like "cancelEditing" or that reminds to it?
| }; | ||
|
|
||
| export default ({ className }: IProps) => ( | ||
| <svg width="12" height="12" viewBox="0 0 12 12" fill="none" xmlns="http://www.w3.org/2000/svg" className={className}> | ||
| export default (props: IProps) => ( |
There was a problem hiding this comment.
There's some differences in the UI for "create comment box". Like the position of the "send message" has changed as well as the initial height and padding of the textarea. Ignore this message if this was part of the new mock up
oggi.mp4
| const ticketId = TicketsCardHooksSelectors.selectSelectedTicketId(); | ||
| const currentUser = CurrentUserHooksSelectors.selectCurrentUser(); | ||
| const isFederation = modelIsFederation(containerOrFederation); | ||
| const [commentreply, setReply] = useState(metadata); |
There was a problem hiding this comment.
The "r" should be capital in commentreply
This fixes #5309
Description
Test cases