-
Notifications
You must be signed in to change notification settings - Fork 40
Issue 5607 - Federations should work without bouncer #5612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sebjf
wants to merge
45
commits into
staging
Choose a base branch
from
ISSUE_5607
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e collection to generate all responses
…mask sequences based on federations too
Hi @carmenfan, this is passing all tests now for when you are back! |
carmenfan
requested changes
Aug 11, 2025
backend/src/v5/processors/teamspaces/projects/models/federations.js
Outdated
Show resolved
Hide resolved
/azp run |
carmenfan
approved these changes
Aug 12, 2025
Azure Pipelines successfully started running 2 pipeline(s). |
looks fine, passing it to @Didi-Kwan for QA Didi we just changed the way federation is created here - so when you edit a federation it should now be instantly updated, this could affect things like tree/group selections so we'd like a general behaviour check on federations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5607
Description
This PR updates the backend so that Federations function without the scene collection having to be maintained by bouncer.
The way it achieves this is to use the existing model settings document to get the Containers in a Federation, in place of the ref nodes. Any properties that are not in this document, but expected by the frontend/viewer in the responses, are generated procedurally. The history collection is still maintained, but by the backend directly.
Generally, the changes are cleanly split between v4 and v5.
The v4 functions are all concerned with getting the submodels for a model, for the purposes of sequences, groups, metadata etc. These functions have been updated to use the v4 getSubModels array, which in turn has been updated to use the model settings document. getRefNodes is now no longer used, though it still exists as it is referenced in a couple of methods that do not seem to be used (all automated & manual tests are passing).
On the v5 side, the changes are concerned with updating a Federation. Instead of building the parameters object and submitting it to the queue, the new functionality updates the model settings document directly and inserts a new revision node into the history*. The old logic has been removed. The new revision node has a
containers
array, but this is for historical information only - the authoritative list of containers is still expected to be the model settings. This ensures backwards compatibility without a migration.(*For this, a stub that imports the v4 history as a v5 module has been created, similar to other utils entries in v5, presumably before they are updated & replaced in the future.)
As above, no migration is needed. If this change functions for a release without issue, a future migration script could remove the redundant scene and ref collections for all legacy federations. Similarly, there no required changes to bouncer or the deployments - that functionality simply won't be used, so can be decommissioned at will in the future.
Finally, not related to the Federations, but the travis.yml has been updated to only check out the required SHA instead of the entire history of the tests repo, saving 2-3 minutes for each build.
Acceptance Criteria
The acceptance criteria is from this ticket, which all passes currently: #5607