-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header - Add authenticated user organization in hidden fields #5288
Header - Add authenticated user organization in hidden fields #5288
Conversation
cc @sigavignon |
@Gustry thanks a lot for the tests. Do you think we should also add other fields (city, postcode, etc.) ? |
If more are added, I would prefer something cleaner (and revert your change in the first commit), using data attributes ? I'm curious what other websites do ? Do they expose all "sensible" data into the frontend ? (with extensions, plugins ...) |
@mdouchin this data could be exposed through jsvars, like dataviz, action, filter, isn't it ? |
Way more comfortable to use |
8fc5cfe
to
0513e4e
Compare
This allows a JavaScript script to get the current user organization and use it in the editing form.
0513e4e
to
9c444a5
Compare
Read onlySummary
Flaky Tests
🔄 This comment has been updated |
Is there still something to do ? I think let's merge but other fields should go in a kind of API, like, like a global function |
ok for merging, and agree with you regarding API |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_8 release_3_8
# Navigate to the new working tree
cd .worktrees/backport-release_3_8
# Create a new branch
git switch --create backport-5288-to-release_3_8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 00fa45a30d995e447b139c8306d1d9c7d5988352,9c444a592d70b978deab382e250c8d25197e2f33
# Push it to GitHub
git push --set-upstream origin backport-5288-to-release_3_8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_8 Then, create a pull request where the |
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_9 release_3_9
# Navigate to the new working tree
cd .worktrees/backport-release_3_9
# Create a new branch
git switch --create backport-5288-to-release_3_9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 00fa45a30d995e447b139c8306d1d9c7d5988352,9c444a592d70b978deab382e250c8d25197e2f33
# Push it to GitHub
git push --set-upstream origin backport-5288-to-release_3_9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_9 Then, create a pull request where the |
This allows a JavaScript script to get the current user organization and use it in the editing form.
Ticket : #
Funded by Ville d'Avignon https://cartes.mairie-avignon.com