Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: JS error if pivotAttributeLayerConf is undefined #5447

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Fix: JS error if pivotAttributeLayerConf is undefined #5447

merged 1 commit into from
Feb 25, 2025

Conversation

nboisteault
Copy link
Member

@nboisteault nboisteault commented Feb 20, 2025 •
edited
Loading

Linked to TDPA issue in 20/02/25 email

@github-actions github-actions bot added this to the 3.10.0 milestone Feb 20, 2025
@nboisteault nboisteault added run end2end If the PR must run end2end tests or not backport release_3_8 backport release_3_9 and removed run end2end If the PR must run end2end tests or not labels Feb 20, 2025
rldhont
rldhont requested changes Feb 21, 2025
View reviewed changes
@rldhont rldhont added editing form javascript Pull requests that update Javascript code labels Feb 25, 2025
@rldhont
Copy link
Collaborator

rldhont commented Feb 25, 2025

@nboisteault I have updated the branch

@Gustry
Copy link
Member

Gustry commented Feb 25, 2025

Thanks @rldhont
I agree, having multiple return False statement makes it easier to read and more robust I think because on multiple lines etc.

@rldhont rldhont merged commit 7a306e1 into 3liz:master Feb 25, 2025
18 of 20 checks passed
This was referenced Feb 25, 2025
Merged
Merged
@nboisteault nboisteault deleted the fix-delete-pivot branch March 3, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rldhont rldhont rldhont requested changes

Assignees
No one assigned
Labels
backport release_3_8 backport release_3_9 editing form javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nboisteault @rldhont @Gustry