-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speedup Lizmap Html page loading by adding preload link #5532
base: master
Are you sure you want to change the base?
Conversation
2265b8c
to
38e13ec
Compare
I'm not sure but it might block the HTML rendering. |
Documentation about preload link https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel/preload
hi @rldhont |
38e13ec
to
a198ef7
Compare
From https://stackoverflow.com/questions/36641137/how-exactly-does-link-rel-preload-work
|
@nboisteault according to mdn, preload should not blocked the page
|
a198ef7
to
0d91bf9
Compare
@@ -16,6 +16,24 @@ class AbstractLizmapHtmlResponse extends jResponseHtml | |||
{ | |||
protected $CSPPropName = 'mapCSPHeader'; | |||
|
|||
protected function outputJsScriptTag($fileUrl, $scriptParams) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These functions will implicitly add a preload
tag for each resource loaded with addJSLink
/addCssLink
, no ?
722ef2c
to
23750aa
Compare
23750aa
to
b24ccb5
Compare
Documentation about preload link https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel/preload