-
-
Notifications
You must be signed in to change notification settings - Fork 153
Speedup Lizmap Html page loading by adding preload link #5532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
2265b8c
to
38e13ec
Compare
I'm not sure but it might block the HTML rendering. |
hi @rldhont |
38e13ec
to
a198ef7
Compare
From https://stackoverflow.com/questions/36641137/how-exactly-does-link-rel-preload-work
|
@nboisteault according to mdn, preload should not blocked the page
|
a198ef7
to
0d91bf9
Compare
{ | ||
protected $CSPPropName = 'mapCSPHeader'; | ||
|
||
protected function outputJsScriptTag($fileUrl, $scriptParams) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These functions will implicitly add a preload
tag for each resource loaded with addJSLink
/addCssLink
, no ?
23750aa
to
b24ccb5
Compare
b24ccb5
to
d7b52cd
Compare
The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale". |
d7b52cd
to
59913be
Compare
59913be
to
758684f
Compare
d268b4b
to
9ec807a
Compare
9ec807a
to
bec60f2
Compare
Documentation about preload link https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel/preload