Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add search domain for split-dns setups #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akostadinov
Copy link

This particularly helps with DNS routers that filter private IP ranges
from responces of public DNS servers.

It is also possible to be done on server side with the option:

push "dhcp-option DOMAIN-SEARCH <SEARCH_DOMAIN>"

Note that this is an openvpn client 2.x option. For 3.x not sure this is supported yet. see https://community.openvpn.net/openvpn/ticket/1209

But in Fedora 36 I see OpenVPN 2.5 being used.

The option is described in man openvpn.

I COULD NOT TEST THIS AS I'M USING Network Manager!!!

This particularly helps with DNS routers that filter private IP ranges
from responces of public DNS servers.
@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raelga for approval by writing /assign @raelga in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot
Copy link
Contributor

@akostadinov: There are no kind on this issue.
Please add an appropriate kind by using one of the following commands:

  • /kind bug
  • /kind cleanup
  • /kind documentation
  • /kind feature
  • /kind <kind-name>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3scale-robot 3scale-robot added the needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. label Sep 22, 2022
@3scale-robot
Copy link
Contributor

Welcome @akostadinov! It looks like this is your first PR to 3scale-ops/aws-cvpn-pki-manager 🎉

@3scale-robot 3scale-robot added needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/XS Requires less than an hour to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. size/XS Requires less than an hour to complete the PR or the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants