By default the Docker run will make use of in-memory mount destinations #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for the application and data path in the standard Postgres Docker image. If in-memory must be disabled, it can be done in the properties. Custom paths can be passed as a list under the inMemoryMountDestinations list. The init process has been revamped to make it less reliable on the first lazy call of getProperties(). The in-memory solution requires a dynamic number of mount mappings. The solution is to insert a template (IN_MEMORY_TEMPLATE), which is transformed into the required number of --mount mappings for Docker. IN_MEMORY_TEMPLATE is hardcoded for now. Not sure if it is sensible to make this customizable.
SanderBenschop
approved these changes
Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #29 by default the Docker run will make use of in-memory mounts for the application and data path in the standard Postgres Docker image. If in-memory must be disabled, it can be done in the properties. Custom paths can be passed as a list under the inMemoryMountDestinations list.
The init process has been revamped to make it less reliable on the first lazy call of getProperties().
The in-memory solution requires a dynamic number of mount mappings. The solution is to insert a template (IN_MEMORY_TEMPLATE), which is transformed into the required number of --mount mappings for Docker. IN_MEMORY_TEMPLATE is hardcoded for now. Not sure if it is sensible to make this customizable.