Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] #232 admin 게임 관리 페이지에서 점수 수정 시 승패 수정 안되는 문제 #467

Conversation

AYoungSn
Copy link
Contributor

📌 개요

  • 승패 수정될 시 counting 오류
  • 새로 카운팅되는게 아니라 값이 추가됨

💻 작업사항

  • db 수정사항 flush 처리
  • 점수 수정 완료 후 tier update

✅ 변경로직

  • db 수정사항 flush 처리
  • 점수 수정 완료 후 tier update

💡Issue 번호

@AYoungSn AYoungSn self-assigned this Dec 29, 2023
@AYoungSn AYoungSn added the bug Something isn't working label Dec 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (673d8b4) 69.57% compared to head (2bdb864) 69.61%.
Report is 1 commits behind head on dev.

Files Patch % Lines
.../gg/server/domain/rank/redis/RankRedisService.java 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #467      +/-   ##
============================================
+ Coverage     69.57%   69.61%   +0.04%     
+ Complexity      824      822       -2     
============================================
  Files           255      255              
  Lines          3783     3795      +12     
  Branches        352      352              
============================================
+ Hits           2632     2642      +10     
- Misses          949      951       +2     
  Partials        202      202              
Flag Coverage Δ
integrationTest 69.32% <93.33%> (+0.04%) ⬆️
unitTest 10.30% <0.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Kimhan-nah
Kimhan-nah previously approved these changes Jan 2, 2024
Copy link
Member

@Kimhan-nah Kimhan-nah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니당!

Copy link
Contributor

@SONGS4RI SONGS4RI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@AYoungSn AYoungSn merged commit 904317e into dev Jan 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants