Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ› [Fix] GUEST ํ† ๋„ˆ๋จผํŠธ ์ฐธ๊ฐ€ ๋ถˆ๊ฐ€๋Šฅํ•˜๋„๋ก ์ˆ˜์ • #483

Closed
wants to merge 7 commits into from

Conversation

Kimhan-nah
Copy link
Member

๐Ÿ“Œ ๊ฐœ์š”

  • GUEST ์œ ์ €๋Š” ํ† ๋„ˆ๋จผํŠธ ์ฐธ๊ฐ€ ๋ถˆ๊ฐ€๋Šฅํ•˜๋„๋ก ์ˆ˜์ •

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • spring security config์—์„œ ํ† ๋„ˆ๋จผํŠธ ์ฐธ๊ฐ€ ์‹ ์ฒญ API๋Š” USER, ADMIN๋งŒ ํ—ˆ์šฉํ•˜๋„๋ก ์„ค์ • ์ถ”๊ฐ€
  • tournament ํ…Œ์ด๋ธ”์˜ contents ์ปฌ๋Ÿผ์„ VARCHAR(3000)์œผ๋กœ ์ˆ˜์ •
  • ํ† ๋„ˆ๋จผํŠธ ์ƒ์„ฑ API, ํ† ๋„ˆ๋จผํŠธ ์ˆ˜์ • API Request DTO์—์„œ @Length๋กœ ๊ธธ์ด ์ œํ•œ

@Kimhan-nah Kimhan-nah added bug Something isn't working enhancement New feature or request labels Jan 4, 2024
@Kimhan-nah Kimhan-nah self-assigned this Jan 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (673d8b4) 69.57% compared to head (f3cc2e8) 69.67%.
Report is 1 commits behind head on main.

Files Patch % Lines
.../gg/server/domain/rank/redis/RankRedisService.java 92.85% 0 Missing and 1 partial โš ๏ธ
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #483      +/-   ##
============================================
+ Coverage     69.57%   69.67%   +0.09%     
+ Complexity      824      822       -2     
============================================
  Files           255      255              
  Lines          3783     3795      +12     
  Branches        352      352              
============================================
+ Hits           2632     2644      +12     
  Misses          949      949              
  Partials        202      202              
Flag Coverage ฮ”
integrationTest 69.38% <87.50%> (+0.09%) โฌ†๏ธ
unitTest 10.30% <6.25%> (+0.28%) โฌ†๏ธ

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@Kimhan-nah Kimhan-nah closed this Jan 4, 2024
@Kimhan-nah Kimhan-nah deleted the hotfix/tournament-security branch January 4, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants