Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ’š [Merge] Merge from dev #484

Merged
merged 4 commits into from
Jan 4, 2024
Merged

πŸ’š [Merge] Merge from dev #484

merged 4 commits into from
Jan 4, 2024

Conversation

Kimhan-nah
Copy link
Member

@Kimhan-nah Kimhan-nah commented Jan 4, 2024

πŸ“Œ κ°œμš”

  • κΈ‰ν•œ μ΄μŠˆλ“€μ— λŒ€ν•œ 1μ°¨ merge

@Kimhan-nah Kimhan-nah added bug Something isn't working enhancement New feature or request labels Jan 4, 2024
@Kimhan-nah Kimhan-nah self-assigned this Jan 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (673d8b4) 69.57% compared to head (c895a3c) 69.61%.
Report is 1 commits behind head on main.

Files Patch % Lines
.../gg/server/domain/rank/redis/RankRedisService.java 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #484      +/-   ##
============================================
+ Coverage     69.57%   69.61%   +0.04%     
+ Complexity      824      822       -2     
============================================
  Files           255      255              
  Lines          3783     3795      +12     
  Branches        352      352              
============================================
+ Hits           2632     2642      +10     
- Misses          949      950       +1     
- Partials        202      203       +1     
Flag Coverage Ξ”
integrationTest 69.32% <87.50%> (+0.04%) ⬆️
unitTest 10.30% <6.25%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

@SONGS4RI SONGS4RI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€!

Copy link
Contributor

@Newsujin Newsujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€ μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€ :)

@Kimhan-nah Kimhan-nah merged commit 5312ab4 into main Jan 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants