Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Fix] tournament contents에 대한 길이 valid 수정 #491

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

Kimhan-nah
Copy link
Member

📌 개요

  • Dto에서 valid check에서 잘못된 길이 제한 수정

💻 작업사항

  • 토너먼트 생성/수정 API에 사용되는 DTO의 contents 길이 제한 1000 -> 3000으로 수정

@Kimhan-nah Kimhan-nah added the bug Something isn't working label Jan 9, 2024
@Kimhan-nah Kimhan-nah self-assigned this Jan 9, 2024
Copy link
Contributor

@SONGS4RI SONGS4RI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8962f7d) 69.73% compared to head (01e2295) 69.76%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #491      +/-   ##
============================================
+ Coverage     69.73%   69.76%   +0.02%     
  Complexity      826      826              
============================================
  Files           255      255              
  Lines          3810     3810              
  Branches        357      357              
============================================
+ Hits           2657     2658       +1     
+ Misses          951      949       -2     
- Partials        202      203       +1     
Flag Coverage Δ
integrationTest 69.47% <ø> (+0.02%) ⬆️
unitTest 10.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Clearsu Clearsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@middlefitting middlefitting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다

@Kimhan-nah Kimhan-nah merged commit bde4915 into main Jan 9, 2024
2 checks passed
@Kimhan-nah Kimhan-nah deleted the hotfix/tournament-contents branch January 9, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants