Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] refactoring api call slack api #493

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

wken5577
Copy link
Contributor

@wken5577 wken5577 commented Jan 9, 2024

๐Ÿ“Œ ๊ฐœ์š”

  • slack๋ด‡ ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ํ•˜๋ คํ–ˆ์œผ๋‚˜ workspace ๊ถŒํ•œ๋ฌธ์ œ๋กœ ์ผ๋‹จ ๋ณด๋ฅ˜ํ•œ ์ƒํƒœ์ž…๋‹ˆ๋‹ค.
  • ๊ธฐ์กด ์™ธ๋ถ€ api๋ฅผ ์—ฐ๋™ํ•˜๋Š” ๋กœ์ง์— ๋ฐ˜๋ณต์ ์ธ ๋ถ€๋ถ„์„ refactoringํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • ์ง€๋„ค๋ฆญ์„ ํ™œ์šฉํ•˜์—ฌ apiCallํ•จ์ˆ˜๋ฅผ ๋”ฐ๋กœ ์ž‘์„ฑํ•˜์—ฌ ๋ฐ˜๋ณต๋กœ์ง ์ œ๊ฑฐ

โœ… ๋ณ€๊ฒฝ๋กœ์ง

๐Ÿ’กIssue ๋ฒˆํ˜ธ

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: 1615 lines in your changes are missing coverage. Please review.

Comparison is base (3193717) 10.25% compared to head (e587bae) 28.13%.
Report is 19 commits behind head on dev.

Files Patch % Lines
...com/gg/server/domain/game/service/GameService.java 0.00% 108 Missing โš ๏ธ
...m/gg/server/domain/match/service/MatchService.java 0.00% 106 Missing โš ๏ธ
...erver/admin/season/service/SeasonAdminService.java 0.00% 94 Missing โš ๏ธ
...min/tournament/service/TournamentAdminService.java 48.76% 80 Missing and 3 partials โš ๏ธ
...gg/server/admin/user/service/UserAdminService.java 0.00% 83 Missing โš ๏ธ
...gg/server/admin/game/service/GameAdminService.java 0.00% 76 Missing โš ๏ธ
...ver/admin/penalty/service/PenaltyAdminService.java 0.00% 47 Missing โš ๏ธ
...penalty/data/PenaltyAdminRepositoryCustomImpl.java 0.00% 43 Missing โš ๏ธ
...admin/slotmanagement/service/SlotAdminService.java 0.00% 41 Missing โš ๏ธ
...java/com/gg/server/domain/game/GameController.java 0.00% 41 Missing โš ๏ธ
... and 91 more
Additional details and impacted files
@@              Coverage Diff              @@
##                dev     #493       +/-   ##
=============================================
+ Coverage     10.25%   28.13%   +17.87%     
- Complexity       78      295      +217     
=============================================
  Files           255      256        +1     
  Lines          3812     3935      +123     
  Branches        357      360        +3     
=============================================
+ Hits            391     1107      +716     
+ Misses         3410     2807      -603     
- Partials         11       21       +10     
Flag Coverage ฮ”
unitTest 28.13% <34.10%> (+17.87%) โฌ†๏ธ

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

@AYoungSn AYoungSn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ApiUtil ํด๋ž˜์Šค ์œ„์น˜๋ฅผ global ๋กœ ์˜ฎ๊ธฐ๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”

Kimhan-nah
Kimhan-nah previously approved these changes Jan 20, 2024
Copy link
Member

@Kimhan-nah Kimhan-nah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค!

AYoungSn
AYoungSn previously approved these changes Jan 31, 2024
Copy link
Contributor

@AYoungSn AYoungSn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธ ์™„๋ฃŒ

@wken5577 wken5577 dismissed stale reviews from AYoungSn and Kimhan-nah via 34e7e96 February 5, 2024 08:42
@wken5577 wken5577 force-pushed the 480-feature-slack-bot-write-channel branch from 34e7e96 to fecc20d Compare February 5, 2024 08:52
@wken5577 wken5577 merged commit 34e533a into dev Feb 5, 2024
1 of 2 checks passed
@Kimhan-nah Kimhan-nah deleted the 480-feature-slack-bot-write-channel branch February 5, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants