Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] rank pagig bug 해결 #494

Merged
merged 2 commits into from
Jan 10, 2024
Merged

[Fix] rank pagig bug 해결 #494

merged 2 commits into from
Jan 10, 2024

Conversation

wken5577
Copy link
Contributor

@wken5577 wken5577 commented Jan 9, 2024

📌 개요

  • exp랑 ppp rank 페이징 버그문제 해결

💻 작업사항

  • query의 limit, offest 인자값 수정하였습니다.
  • offset값은 pagenum * pagesize로 계산하도록 수정
  • 테스트 코드는 이후 작성해서 pr다시 올리겠습니다

✅ 변경로직

💡Issue 번호

@wken5577 wken5577 self-assigned this Jan 9, 2024
@wken5577 wken5577 linked an issue Jan 9, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (01e2295) 69.97% compared to head (c0dc457) 69.56%.
Report is 1 commits behind head on dev.

Files Patch % Lines
...com/gg/server/domain/rank/service/RankService.java 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #494      +/-   ##
============================================
- Coverage     69.97%   69.56%   -0.41%     
+ Complexity      829      822       -7     
============================================
  Files           255      255              
  Lines          3810     3812       +2     
  Branches        357      357              
============================================
- Hits           2666     2652      -14     
- Misses          945      955      +10     
- Partials        199      205       +6     
Flag Coverage Δ
integrationTest 69.28% <0.00%> (-0.41%) ⬇️
unitTest 10.25% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wken5577 wken5577 changed the title rank pagig bug 해결 [Fix] rank pagig bug 해결 Jan 9, 2024
@wken5577 wken5577 added the bug Something isn't working label Jan 9, 2024
Copy link
Contributor

@AYoungSn AYoungSn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다:)

Copy link
Member

@Kimhan-nah Kimhan-nah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엘지티엠입니다

@wken5577 wken5577 merged commit 4b1d01e into dev Jan 10, 2024
1 check passed
Newsujin pushed a commit that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] rank 조회 시 paging query 오류
4 participants