Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] 392 bug main flyway와 test schemasql 불일치 #498

Merged
merged 5 commits into from
Jan 13, 2024

Conversation

middlefitting
Copy link
Member

@middlefitting middlefitting commented Jan 10, 2024

📌 개요

  • 기존 flyway 내용은 alter 문법부터 시작하기 때문에 test 환경에서 flyway 파일로 ddl을 적용하는 것이 불가능했습니다. 기존 테이블 정보를 구해보려했지만 찾을 수 없었고, 테스트 환경에서는 dump 파일에서 뽑은 �스키마를 schma.sql 에 적어 진행하였습니다.
  • 하지만 main에서는 flyway, test에서는 shema 파일로 관리하는 것은 두 파일의 불일치 문제에 대한 검증이 어렵습니다.
  • 또한 기존 flyway는 초기 dump 파일이 없으면 실행이 불가능하다는 점에서 효용이 떨어집니다.
  • 따라서 flyway 파일을 타노스 하고 dump 파일에서 가져온 초기화 sql 부터 시작하는 것으로 변경합니다.
  • 병합전에 dev, main 서버에 flyway 테이블은 직접 수정하겠습니다.

💻 작업사항

  • flyway 수정
  • schma.sql 제거
  • flyway가 모든 mysql 컨테이너 초기화되도록 빌드를 context에서 진행
  • 테스트용 애노테이션 수정

💡Issue 번호

@middlefitting middlefitting added the bug Something isn't working label Jan 10, 2024
@middlefitting middlefitting self-assigned this Jan 10, 2024
@middlefitting middlefitting linked an issue Jan 10, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8962f7d) 69.73% compared to head (e58dc93) 69.70%.
Report is 4 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #498      +/-   ##
============================================
- Coverage     69.73%   69.70%   -0.04%     
  Complexity      826      826              
============================================
  Files           255      255              
  Lines          3810     3812       +2     
  Branches        357      357              
============================================
  Hits           2657     2657              
- Misses          951      954       +3     
+ Partials        202      201       -1     
Flag Coverage Δ
integrationTest 69.41% <ø> (-0.04%) ⬇️
unitTest 10.25% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@middlefitting middlefitting changed the title [ FIX ] 392 bug main flyway와 test schemasql 불일치 [Fix] 392 bug main flyway와 test schemasql 불일치 Jan 10, 2024
Copy link
Contributor

@SONGS4RI SONGS4RI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인하였습니다!

Copy link
Member

@Kimhan-nah Kimhan-nah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AYoungSn AYoungSn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

설명 잘 들었습니다! 수고하셨습니다:)

Copy link
Contributor

@wken5577 wken5577 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~~ 설명 굿!

@middlefitting middlefitting merged commit ed1d638 into dev Jan 13, 2024
1 check passed
@middlefitting middlefitting deleted the 392-bug-main-flyway와-test-schemasql-불일치 branch January 13, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] main flyway와 test schema.sql 불일치
6 participants