Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ§ͺ [Unit Test] Item μœ λ‹›ν…ŒμŠ€νŠΈ μΆ”κ°€ 및 μžλ°”λ… μΆ”κ°€ 및 μžμž˜ν•œ μ½”λ“œ 닀듬기 #507

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

SONGS4RI
Copy link
Contributor

@SONGS4RI SONGS4RI commented Jan 15, 2024

πŸ“Œ κ°œμš”

  • Item μœ λ‹›ν…ŒμŠ€νŠΈ μΆ”κ°€
  • μžλ°”λ… μΆ”κ°€
  • μžμž˜ν•œ μ½”λ“œ 닀듬기

πŸ’» μž‘μ—…μ‚¬ν•­

  • ItemService
    • purchaseItem() && giftItem(): 할인가 μ •ν•˜λŠ” 둜직 λ‹€λ“¬μ—ˆμŠ΅λ‹ˆλ‹€.

βœ… λ³€κ²½λ‘œμ§

  • verify μΆ”κ°€
  • 넀이버 μ»¨λ²€μ…˜ 적용

πŸ’‘Issue 번호

@SONGS4RI SONGS4RI added documentation Improvements or additions to documentation test labels Jan 15, 2024
@SONGS4RI SONGS4RI self-assigned this Jan 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (c99110c) 69.72% compared to head (e7e585a) 71.92%.
Report is 5 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #507      +/-   ##
============================================
+ Coverage     69.72%   71.92%   +2.19%     
- Complexity      826      860      +34     
============================================
  Files           255      255              
  Lines          3812     3818       +6     
  Branches        357      357              
============================================
+ Hits           2658     2746      +88     
+ Misses          953      872      -81     
+ Partials        201      200       -1     
Flag Coverage Ξ”
integrationTest 69.72% <13.33%> (+0.28%) ⬆️
unitTest 13.51% <100.00%> (+3.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

middlefitting
middlefitting previously approved these changes Jan 21, 2024
Copy link
Member

@middlefitting middlefitting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κΌΌκΌΌν•˜κ²Œ μž‘μ„±ν•΄μ£Όμ…¨λ„€μš”. κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€! πŸ‘

@SONGS4RI SONGS4RI marked this pull request as draft January 26, 2024 04:09
@SONGS4RI SONGS4RI marked this pull request as ready for review January 27, 2024 07:16
@Kimhan-nah Kimhan-nah marked this pull request as draft January 30, 2024 11:08
@SONGS4RI SONGS4RI marked this pull request as ready for review January 31, 2024 10:45
Copy link
Contributor

@Newsujin Newsujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€ μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹€!!

@SONGS4RI SONGS4RI merged commit 35b09b1 into dev Feb 5, 2024
2 checks passed
@SONGS4RI SONGS4RI deleted the item-unit-test branch February 5, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

πŸ§ͺ [Test] Item ν…ŒμŠ€νŠΈ μ½”λ“œ
4 participants