Add Turkish language support to the application close #1397#1399
Open
ramazansancar wants to merge 7 commits into6c65726f79:mainfrom
Open
Add Turkish language support to the application close #1397#1399ramazansancar wants to merge 7 commits into6c65726f79:mainfrom
ramazansancar wants to merge 7 commits into6c65726f79:mainfrom
Conversation
Author
|
Check pls @6c65726f79 |
fix(main): comment out temporary fix for injected property warning refactor(TransmissionRPC): improve code readability and consistency; add error handling for free space check feat(UserSettings): implement server list export/import functionality fix(App): ensure selected filter is set correctly when loading servers fix(List): handle unknown free space scenario gracefully feat(Settings): add buttons for server list export, import, and reset; implement server validation refactor(TorrentDetails): remove unused animation imports for modals refactor(StatsPopover): enhance table structure with thead and tbody for better semantics chore(vue.config): set up dev server proxy for handling TRPC requests
There was a problem hiding this comment.
Pull request overview
This PR adds Turkish language support to the application and implements several infrastructure improvements including server export/import functionality, modal animations, development proxy support, and various bug fixes.
Changes:
- Added complete Turkish (tr) language translation file with 256 localized strings
- Implemented server configuration export/import/reset functionality in Settings
- Created custom modal animations to replace platform-specific Ionic Core imports
- Added development server proxy for TRPC requests to avoid CORS issues
- Enhanced error handling and state management for edge cases
Reviewed changes
Copilot reviewed 35 out of 36 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| public/locales/tr.json | New Turkish translation file with complete locale strings |
| src/views/Settings.vue | Added server export/import/reset UI and logic |
| src/services/LocaleController.ts | Registered Turkish locale in language list |
| README.md | Added Turkish translator credit |
| src/services/ModalAnimations.ts | New custom modal animation implementation |
| src/views/App.vue | Integrated custom animations and improved server state handling |
| src/views/List.vue | Replaced platform-specific animations with custom ones |
| src/views/TorrentDetails.vue | Replaced platform-specific animations with custom ones |
| src/services/UserSettings.ts | Enhanced server list loading with fallback mechanism |
| src/services/TransmissionRPC.ts | Code formatting and development proxy support |
| vue.config.js | Added development server proxy middleware |
| src/views/components/StatsPopover.vue | Added proper table structure with thead/tbody |
| src/main.ts | Commented out deprecated config option |
| package.json | Updated dependencies (lodash, ionicons, parse-torrent) |
| public/locales/*.json | Added "unknown" translation key to all locale files |
| .gitignore | Added pnpm-lock.yaml to ignore list |
Comments suppressed due to low confidence (2)
src/views/Settings.vue:1
- The variable 'parsed' has an overly generic name and uses 'any' type. Consider renaming to 'parsedData' or 'importedServerData' for clarity.
src/views/App.vue:1 - The condition checks both selectedServer and torrentFilters in the template. Consider moving this logic to a computed property for better readability and testability.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1397
Issues related to libraries, etc., that prevented the system from working properly on the first run have been resolved, and it is now fully functional. Buttons have been added to the settings section for importing and exporting servers.