-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy FRE-NCtools prerelease #45
base: main
Are you sure you want to change the base?
Conversation
🚀 Attempted to deploy 🖥️
|
Hi @dougiesquire , You'll have to update |
Good point, thanks @harshula I realise I'm also unclear on how to include |
🚀 Attempted to deploy 🖥️
|
Ugh. I thought we could add more in the spec, and only the first entry was special, but I may have been mistaken. I defer to @CodeGat for the definitive word. You're right that it won't be installed if it's just a package and nothing depends on it. So if we can't include in the Sorry if this is a mite more complex than I might have made out ... ;) <airly waves hands> |
🚀 Attempted to deploy 🖥️
|
🚀 Attempted to deploy 🖥️
|
🚀 Attempted to deploy 🖥️
|
🚀 Attempted to deploy 🖥️
|
🚀 Attempted to deploy 🖥️
|
I can update the schema to allow more than one spec, pending a discussion with the team tomorrow. I understand that there is appetite for (for example) having multiple compilers being built at once, etc, which we should support I think - especially since the Build CI 2.0 will make heavy use of matrix builds etc. The main reason for requiring a single spec is that a Release should be as simple as possible, containing a single model. Maybe Prereleases shouldn't have that restriction, but it will be difficult to enforce that kind of thing at merge-time. Maybe it can be another relaxing of the rules that is already in place with Draft PRs... 🤔 anyway, I'll update this tomorrow with more thoughts. |
🚀 Attempted to deploy 🖥️
|
🚀 Attempted to deploy 🖥️
|
I'm a dimwit and I've made an absolute hash of this PR. But I think I have managed to inveigle the CI checks and get a working prerelease of FRE-NCtools:
@aidanheerdegen, @CodeGat let me know if you're okay with what's done here. If so, I might close this and redo in a new PR to tidy things up a bit. |
I don't know how you managed to ballerina tip toe around the restrictions so elegantly but I'm impressed, and a little scared. I'll chat with @aidanheerdegen today 😁 |
He's ditched ACCESS-OM3 completely, which ISTR I had mentioned as a possibility in another discussion, but had subsequently forgotten, so sorry if that took longer than it should have. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't merge this!
DO NOT MERGE
This is a PR to create a prerelease of FRE-NCtools. This is very much a stop-gap to provide a deployment of FRE-NCtools while we work out the best way to release these sorts of tools.
To get around the CI checks, this PR replaces the
access-om3
spec in the environment withfre-nctools
.See #44
🚀 The latest prerelease
access-om3/pr45-3
at bad5555 is here: #45 (comment) 🚀