Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Historical: add basin mask for basin specific diagnostics #102

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

blimlim
Copy link

@blimlim blimlim commented Nov 18, 2024

Closes the historical half of #95.

This PR sets MOM to read the basin_mask.nc input file which allows for basin specific tracer diagnostics (e.g. temp_merid_flux_over_atlantic) to be saved.

Verified

This commit was signed with the committer’s verified signature.
blimlim Spencer Wong

Verified

This commit was signed with the committer’s verified signature.
blimlim Spencer Wong

Verified

This commit was signed with the committer’s verified signature.
blimlim Spencer Wong
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just checking: are there are diagnostics in the standard profiles that use the basin mask?

@blimlim
Copy link
Author

blimlim commented Nov 20, 2024

are there are diagnostics in the standard profiles that use the basin mask?
There are! We're currently saving several of these 1D flux variables incorrectly because of the missing basin mask:

'monthly 1d ocean fields':
defaults: # these can be overridden for individual fields below
file_name_dimension: 1d # descriptor for filename, e.g. 3d, 2d, scalar
output_freq: 1 # integer: output sampling frequency in output_freq_units (0: every timestep; -1: only at end of run)
output_freq_units: months # time units for output: years, months, days, hours, minutes, or seconds
file_name:
- file_name_prefix
- file_name_dimension
- output_freq
- '':
- output_freq_units
- file_name_date
fields:
geolat_c: {reduction_method: 'snap'} # See https://github.com/ACCESS-NRI/access-esm1.5-configs/issues/74
temp_merid_flux_advect_global:
temp_merid_flux_over_global:
temp_merid_flux_gyre_global:
salt_merid_flux_advect_global:
salt_merid_flux_over_global:
salt_merid_flux_gyre_global:
temp_merid_flux_advect_southern:
temp_merid_flux_over_southern:
temp_merid_flux_gyre_southern:
salt_merid_flux_advect_southern:
salt_merid_flux_over_southern:
salt_merid_flux_gyre_southern:
temp_merid_flux_advect_atlantic:
temp_merid_flux_over_atlantic:
temp_merid_flux_gyre_atlantic:
salt_merid_flux_advect_atlantic:
salt_merid_flux_over_atlantic:
salt_merid_flux_gyre_atlantic:
temp_merid_flux_advect_pacific:
temp_merid_flux_over_pacific:
temp_merid_flux_gyre_pacific:
salt_merid_flux_advect_pacific:
salt_merid_flux_over_pacific:
salt_merid_flux_gyre_pacific:
temp_merid_flux_advect_arctic:
temp_merid_flux_over_arctic:
temp_merid_flux_gyre_arctic:
salt_merid_flux_advect_arctic:
salt_merid_flux_over_arctic:
salt_merid_flux_gyre_arctic:
temp_merid_flux_advect_indian:
temp_merid_flux_over_indian:
temp_merid_flux_gyre_indian:
salt_merid_flux_advect_indian:
salt_merid_flux_over_indian:
salt_merid_flux_gyre_indian:

as brought up here: https://forum.access-hive.org.au/t/access-esm1-5-basin-ocean-heat-transports-incorrect/3674

@blimlim blimlim merged commit 60d686c into dev-historical+concentrations Nov 20, 2024
10 checks passed
@blimlim blimlim deleted the 95-add-basin-mask-historical branch November 20, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants