Creation of a Common Version Provenance File #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeGat
force-pushed
the
98-spack-version-provenance
branch
from
79c653d to
de74681
Compare
CodeGat
force-pushed
the
98-spack-version-provenance
branch
from
855c8de to
67342ea
Compare
… to include spack hashes
…ployment-settings action code
…in release are in prerelease, updated hash equality check to exclude majors that are not in both pre/release
CodeGat
force-pushed
the
98-spack-version-provenance
branch
from
62c4c15 to
a34bb0b
Compare
…ired and no default, updated usages in repo
aidanheerdegen
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This is a big one, which all stemmed from the want to be able to control more finely the version of
spackthat was used for a givenreleases/VERSIONbranch.This evolved into a
config/settings.jsonfile that is the source of truth for versions of repositories that we do not want people to modify freely on a model repository basis.This then allowed various checks on the versions of
spackinstalled (for example, warning the user that thePrereleasespackhas a different hash to theReleasespack.This then evolved into workflow that, based on modifications to said
config/settings.json, would update the versions ofspackon the deployment target, so we don't have to get our hands dirty.Thanks to @harshula for the conversations that led to this.
Outline
In this PR:
config/settings.json(andsettings.schema.json) file that has the git commit ofaccess-nri/spackthat is used for allrelease/VERSIONs. See b5424bf.github/CODEOWNERSfile that requires a member of Model Release to sign off on modifications toconfig/settings.json. See a888e5f.github/actions/validate-deployment-settingsaction that verifies the correctness of variousconfig/settings.jsonfields, and added this action to bothci.ymlandcd.yml. See d10f21fsettings-*.ymlthat fires on modification ofconfig/settings.json, that updates the versions ofspackused on the deployment target (like Gadi). See de74681Testing
jqwas tested locally on the same file for validityCloses #98