Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Settings Matrix Generation to Adhere to settings.schema.json #232

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

CodeGat
Copy link
Member

@CodeGat CodeGat commented Feb 21, 2025

Background

Fixes regression introduced in #218 in which we attempted to generate a matrix of targets without adhering to the config/settings.schema.json, leading to an empty (null) matrix and a failed workflow: see https://github.com/ACCESS-NRI/build-cd/actions/runs/13451909066/job/37587737547?pr=228

The PR

In this PR:

  • Update matrix generation to conform with existing schema - the key is deployment not deployments, and we only require the keys, not the entire object.

Testing

Tested jq locally - ran jq -cr '.deployment | keys' config/settings.json at a949ae0 and got expected ["Gadi"].

Tested matrix generated successfully in test workflow: https://github.com/codegat-test-org/test/actions/runs/13452297829

@CodeGat
Copy link
Member Author

CodeGat commented Feb 21, 2025

Going to merge and ask for forgiveness on this one. Testing above is sufficient to ensure correctness.

@CodeGat CodeGat merged commit 5dec031 into v4 Feb 21, 2025
@CodeGat CodeGat deleted the fix-settings-target-generation branch February 21, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done ✅
Development

Successfully merging this pull request may close these issues.

1 participant