Undeploy: Export DEPLOYMENT_TARGET before removing environments #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #242
Background
A curious regression introduced in #218, is that now that we can (and have, in
ACCESS-TEST
Prereleases) use the set-at-install-time environment variableDEPLOYMENT_TARGET
in ourspack.yaml
s,spack
expects it to be set. Interestingly,spack
now errors out when it can't find it, since it loads config from all existing environmentsspack.yaml
while uninstalling some environments, including ones that requireDEPLOYMENT_TARGET
.The PR
In this PR:
DEPLOYMENT_TARGET
before undeploying environmentsTesting
Tested uninstallation of a dummy enviroment in Prerelease without exporting
DEPLOYMENT_TARGET
which fails as expected.Exported
DEPLOYMENT_TARGET
and then attempted uninstallation, which succeeded.