-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Successful Repro Pipeline Errors #56
Conversation
…at source version is not empty as well
79b3938
to
135c62d
Compare
135c62d
to
0bf1601
Compare
Bugger. Now I remember we missed the step of merging the version from Does the new logic mean we never have to do this? I don't think it's a good idea, so perhaps we should special case when the |
I think that the solution is to have modified the version to The real solution is to add another trigger to the version bumping stuff on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give it a rip!
This PR fixes a couple of errors found when a config successfully reproduces, namely:
'1.0'
) against dev (''
), seeing that the versions were different, and allowing merging. We now check for''
, not justnull
. See 89d6d6c and 6a36a4c. See Workflow Log Annotation.And fixes up some variables in comments:
${{ needs.repro-test.outputs.artifact-url }}
but that wasn't actually an output to that job, so it would be the empty string. Added it in 3ddef0d. See end of PR comment Update release preindustrial+concentrations configuration access-esm1.5-configs#86 (comment)Linking failed PRs ACCESS-NRI/access-esm1.5-configs#86 and ACCESS-NRI/access-esm1.5-configs#87
Closes #57